Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Update Spanish translation #5996

Merged
merged 1 commit into from
Oct 22, 2021
Merged

[No QA] Update Spanish translation #5996

merged 1 commit into from
Oct 22, 2021

Conversation

pecanoro
Copy link
Contributor

Spanish translation didn't make any sense.

Fixed Issues

$ #5990

Tests

  1. Navigate to add bank account flow (app must be in spanish)
  2. Add a Verifying bank account (must go through onfido flow)
  3. Reach the "Let's finish in chat" Modal.
  4. Spanish copy should have been updated, instead of "Acabemos en el chat" and "Gracias por hacer eso", it should say "Continuemos en el chat" and "Gracias" respectively.

QA Steps

No QA.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@pecanoro pecanoro requested a review from a team as a code owner October 22, 2021 00:57
@pecanoro pecanoro self-assigned this Oct 22, 2021
@MelvinBot MelvinBot requested review from yuwenmemon and removed request for a team October 22, 2021 00:58
yuwenmemon
yuwenmemon approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@yuwenmemon yuwenmemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bueno!

@yuwenmemon yuwenmemon merged commit dee1da5 into main Oct 22, 2021
@yuwenmemon yuwenmemon deleted the rocio-FixTranslation branch October 22, 2021 01:43
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Oct 23, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @yuwenmemon in version: 1.1.8-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@roryabraham roryabraham changed the title Update Spanish translation [No QA] Update Spanish translation Oct 25, 2021
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuwenmemon yuwenmemon yuwenmemon approved these changes

Assignees

@pecanoro pecanoro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pecanoro @OSBotify @yuwenmemon