Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Chat - Search results are covered by a blank area #6097

Closed
isagoico opened this issue Oct 28, 2021 · 9 comments
Closed

New Chat - Search results are covered by a blank area #6097

isagoico opened this issue Oct 28, 2021 · 9 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@isagoico
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open New Expensify
  2. Click on the FAB
  3. Click on New Chat
  4. Search for a user

Expected Result:

Search result area is displayed without visual issues.

Actual Result:

Search results area is not visible and covered by a blank area.

Workaround:

None found.

Platform:

Where is this issue occurring?

  • iOS

Version Number: 1.1.10-1

Reproducible in staging?: Yes
Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: @rafecolton
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1635344826167600

View all open jobs on GitHub

@MelvinBot
Copy link

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@isagoico
Copy link
Author

Adding the deploy blocker label. Issue is not reproducible in Prod

@isagoico isagoico added the DeployBlockerCash This issue or pull request should block deployment label Oct 28, 2021
@github-actions github-actions bot added Hourly KSv2 and removed Daily KSv2 labels Oct 28, 2021
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@roryabraham
Copy link
Contributor

roryabraham commented Oct 28, 2021

I'm not able to reproduce this on main (at least not on an iOS 15 simulator)

@roryabraham
Copy link
Contributor

Okay, I was able to reproduce this on a physical iPhone 11 w/ iOS 14.8

@roryabraham
Copy link
Contributor

I was able to confirm that reverting https://github.com/Expensify/App/pull/5891/files does not fix this issue

@jasperhuangg
Copy link
Contributor

jasperhuangg commented Oct 28, 2021

Is this something to do with how Apple's WebKit handles stuff like flex: 1 differently from Chromium based browsers/devices? There might have been a style change that wasn't tested on iOS before being merged.

@roryabraham
Copy link
Contributor

Interestingly, this PR combined the NewChatPage and the NewGroupPage into a shared component, but only the NewChatPage is affected in this issue, not the NewGroupPage.

@roryabraham
Copy link
Contributor

Got a fix, PR incoming...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants