Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: list is cut off at bottom in LHN #5891

Merged
merged 2 commits into from
Oct 20, 2021
Merged

Fix: list is cut off at bottom in LHN #5891

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66f269a
fix: bottom list is cut off in LHN
parasharrajat Oct 15, 2021
2b23568
remove comment
parasharrajat Oct 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions src/components/Modal/index.ios.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,15 @@
import React from 'react';
import {SafeAreaView} from 'react-native';
import withWindowDimensions from '../withWindowDimensions';
import BaseModal from './BaseModal';
import {propTypes, defaultProps} from './ModalPropTypes';

// Only want to use <SafeAreaView> on iOS. Avoids ScrollBar in the middle of the modal.
// https://github.com/facebook/react-native/issues/26610
const Modal = props => (
<SafeAreaView>
<BaseModal
<BaseModal
// eslint-disable-next-line react/jsx-props-no-spreading
{...props}
>
{props.children}
</BaseModal>
</SafeAreaView>

{...props}
>
{props.children}
</BaseModal>
);

Modal.propTypes = propTypes;
Expand Down