Deploy Checklist: New Expensify 2021-11-29

[OSBotify]

Release Version: 1.1.17-7
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Added Keyboard shortcuts modal #6112

  • QA
  • Accessibility

• Do not include CP merge commits in the list of PR merge commits #6165

  • QA
  • Accessibility

• Bump react-native-onyx to next version #6195

  • QA
  • Accessibility

• [No QA] Fix dependency cycles #6266

  • QA
  • Accessibility

• Fix inverted list by applying forked version of react-native-web #6268

  • QA
  • Accessibility

• Improve inline icons - Address 5873 #6271

  • QA
  • Accessibility

• Supports big screens mobile devices for popover menu #6278

  • QA
  • Accessibility

• Standardize imports #6279

  • QA
  • Accessibility

• Fix the android status bar color change on app launch #6387

  • QA
  • Accessibility

• Fix URL rendering #6392

  • QA
  • Accessibility

• [No QA] Update webpack path for apple app association #6408

  • QA
  • Accessibility

• Fix IOU Modal styles. #6417

  • QA
  • Accessibility

• Strip prefix and translate pronouns when needed #6419

  • QA
  • Accessibility

• [NO QA] Revert "Ensures mini actions menu will disappear when attachment modal opens up" #6429

  • QA
  • Accessibility

• [No QA] Update webpack so the apple association file is served from .well-known directory #6430

  • QA
  • Accessibility

• [NO QA] Revert "Fix : Pressing Tab button in AddressSearch inputs" #6431

  • QA
  • Accessibility

• fix: Secondary login page #6433

  • QA
  • Accessibility

• [NO QA] Revert "Revert "Ensures mini actions menu will disappear when attachment modal opens up"" #6434

  • QA
  • Accessibility

• fix issue 6326: Chat - Magnifying glass displayed anywhere #6437

  • QA
  • Accessibility

• Revert "Merge pull request #6268 from azimgd/fix-inverted-list" #6441

  • QA
  • Accessibility

• Fix: Blurred images in attachment view on mobile devices #6442

  • QA
  • Accessibility

• Remove div usage in Onfido Web #6454

  • QA
  • Accessibility

• Prevent cannot read property of undefined for href.startsWith #6456

  • QA
  • Accessibility

• remove deleted comment message on new chats #6458

  • QA
  • Accessibility

• fix: newline via updating the count first before marking the messages as read #6459

  • QA
  • Accessibility

• [NO QA] fix: crash #6462

  • QA
  • Accessibility

• Remove extra margin #6466

  • QA
  • Accessibility

• Encode secondary login URL #6479

  • QA
  • Accessibility

• [No QA] Fix const import on staging #6483

  • QA
  • Accessibility

• Encode oldDot links with param in the URL #6485

  • QA
  • Accessibility

Internal QA:

• Testing #32409 (part2) #6440 - @pecanoro @MariaHCD
• Testing PR #32409 #6423 - @johnmlee101 @pecanoro

Deploy Blockers:

• Web - Attachments - Unable to get to the top of images with long height and not able to zoom #6518
• Chat - Add attachment - Menu is misplaced and will break screen layout #6519
• Profile - Context menu opens at the top of the page and unable to select an option when adding profile photo #6520
• Chat - Emoticons appear shifted to right and not fully visible #6522
• mWeb - Safari / Chrome - Profile - Not able to add space and brackets for phone number #6525
• iPad - Chat - Popover menu animated from the bottom instead of from side #6529
• mWeb - IOU - Blank page displayed tapping continue from Verify identity page #6534

cc @Expensify/applauseleads

[MelvinBot]

📣 @applausebot You have been assigned to this job by @OSBotify!
Please apply to this job in Upwork and let us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[roryabraham]

Something weird happened here, going to unlock and relock

[roryabraham]

Trying again

[roryabraham]

Okay, that time it worked and 1.1.17-0 is deploying here

[parasharrajat]

#6433 is in production already.

[roryabraham]

@parasharrajat This is a known issue with pull requests that are CP'd. We should be close to a fix, but won't know for sure until the next checklist. Checked off #6433 for now

[mvtglobally]

Regression is almost complete
Issues found

• Web - Attachments - Unable to get to the top of images with long height and not able to zoom #6518
• Chat - Add attachment - Menu is misplaced and will break screen layout #6519
• Profile - Context menu opens at the top of the page and unable to select an option when adding profile photo #6520
• Chat - Emoticons appear shifted to right and not fully visible #6522
• iPad - Chat - Popover menu animated from the bottom instead of from side #6529
• mWeb - IOU - Blank page displayed tapping continue from Verify identity page #6534

TCs Blocked
Log in / Messages / Notifications iOS/Android and mWeb TCs Blocked by #6519
iOS - Settings - blocked by #6520
iOS - Bank Account - Blocked by #6438

[isagoico]

@roryabraham @marcaaron Got the notification to test these Cherry picks but both seem internal QA. I'll add them to the Internal list of PRs in the main comment.
#6531
#6411

[roryabraham]

Verified #6531 on staging, checking it off.

[roryabraham]

#6165 Will not be fully verified until the next checklist, but we've seen so far that it doesn't cause any regression. So I'm going to check it off on this checklist. cc @mountiny

[mvtglobally]

Checking off #6278 as Fix #6523 is Pass

[mvtglobally]

#6548 & #6454 both retests Pass

[isagoico]

@roryabraham Botify didn't like me adding stuff to the checklist 😆 I think what we can do is simply add comments with checklists to test the CPs until the CP checklist issue is resolved so we have visibility on what has been tested or not.

[isagoico]

Only thing missing for this checklist is the fix for #6518 (deploy blocker) being worked on here #6535 - once that it fixed we will retest #6442 and check both of them off if they are a pass.

[roryabraham]

Botify didn't like me adding stuff to the checklist

Oh, I can fix that 😄 Mind creating an issue and assigning it to me?

[ogumen]

The PRs not applicable to accessibility testing are: #6165, #6195, #6268, #6278, #6279, #6387, #6441, #6417, #6466, #6485. All others except #6442 have been tested, the failures are mentioned in comments for the corresponding PRs.

[isagoico]

Testing this CP on all environments:
#6259

Will be tested internally #6571 (comment)

[marcaaron]

#6411 should be good to go - removing the blocker.

[mvtglobally]

@roryabraham Friendly bump.
Still waiting for the fix for #6518 (deploy blocker) to retest #6442 & close this checklist

[roryabraham]

@mvtglobally We're working on getting #6518 resolve ASAP.

[roryabraham]

The fix to #6518 is being CP'd in 1.1.17-7 here

[roryabraham]

1.1.17-7 has finished deploying. @mvtglobally @isagoico please retest #6442, #6518, and #6535

[mvtglobally]

@roryabraham #6518 and #6535 are pass. 1.1.17-7 is not available on Android yet, but PR #6442 seem pass on build 1.1.17-6 on Android. Let me know if we should wait for 1.1.17-7 or it is ok to check off this PR?

[roryabraham]

Sounds good, going to check everything off and deploy.

[roryabraham]