Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat - Add attachment - Menu is misplaced and will break screen layout #6519

Closed
kavimuru opened this issue Nov 29, 2021 · 6 comments · Fixed by #6523
Closed

Chat - Add attachment - Menu is misplaced and will break screen layout #6519

kavimuru opened this issue Nov 29, 2021 · 6 comments · Fixed by #6523
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open app and login
  2. Go to any chat
  3. Tap on + > Add Attachment

Expected Result:

Add Attachment menu is properly shown

Actual Result:

'Add Attachment' menu is hugely misplaced

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS
  • Android

Version Number: 1.1.17-0

Reproducible in staging?: Yes

Reproducible in production?: No

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:
Bug5350742_image

Bug5350742_20211129_181458.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Nov 29, 2021
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kavimuru
Copy link
Author

This happens in payment page too where context menu should open.
Image from iOS

@mountiny
Copy link
Contributor

Seems also related to the other deploy blocker: #6520

@cead22 cead22 removed their assignment Nov 29, 2021
@cead22
Copy link
Contributor

cead22 commented Nov 29, 2021

I agree, I'm gonna throw the demolition label on this one since we have clear steps to reproduce

@MelvinBot
Copy link

Triggered auto assignment to @TomatoToaster (Demolition), see https://stackoverflow.com/c/expensify/questions/8099 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants