Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS - Profile - Error message when uploading a photo using camera #6628

Closed
kavimuru opened this issue Dec 7, 2021 · 9 comments
Closed

iOS - Profile - Error message when uploading a photo using camera #6628

kavimuru opened this issue Dec 7, 2021 · 9 comments
Assignees
Labels
Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@kavimuru
Copy link

kavimuru commented Dec 7, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open staging New Expensify App
  2. Log in
  3. Select settings by clicking the avatar at the top right of the menu
  4. Select Profile
  5. Tap the camera icon on the avatar
  6. From the pop up menu select Upload photo
  7. Choose Take photo
  8. Take a random image and upload

Expected Result:

Image would upload with no issues

Actual Result:

Error pop up each time and unable to upload image taken with error message "Image upload failed “The selected image exceeds the maximum upload size of 3MB”"
When you check the image size, it it actually less than 3MB

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS

Version Number: 1.1.18-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5362641_C7A1B49C-2ACC-47A9-9272-684F8CBC0CDD

Bug5362641_IMG_2016.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

@MelvinBot
Copy link

Triggered auto assignment to @nickmurray47 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@nickmurray47
Copy link
Contributor

Going to unassign for now since I'm running into issues with Xcode on dev. I'm assuming this can be worked on externally as long as there aren't any existing issues with our current file upload API in Web-E.

@nickmurray47 nickmurray47 removed their assignment Dec 8, 2021
@akshayasalvi
Copy link
Contributor

I had reported this earlier: #6554 and it was closed based on this #6554 (comment)

@MelvinBot
Copy link

Eep! 4 days overdue now. Issues have feelings too...

@MelvinBot
Copy link

6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@MelvinBot
Copy link

10 days overdue. Is anyone even seeing these? Hello?

@Jag96
Copy link
Contributor

Jag96 commented Dec 21, 2021

It looks like we set the max value for the upload here, which was added in this PR. When testing, it looks like the values for taking a photo with the front camera and back camera were both over 3MB, here are those values (respectively):

image

Asked in slack here to confirm this value is ok to update to 6MB, otherwise we'll need to look into another fix for this. This can likely be external, but waiting for confirmation before updating.

@MelvinBot MelvinBot removed the Overdue label Dec 21, 2021
@mananjadhav
Copy link
Collaborator

Proposal if made external

This is just a small config change. Need to update the value for CONST.AVATAR_MAX_ATTACHMENT_SIZE as 6291456.

I've checked that it successfully uploads and there isn't any error thrown from the API.

@Jag96
Copy link
Contributor

Jag96 commented Dec 21, 2021

Already had the branch up for this one so just made the PR myself

@Jag96 Jag96 self-assigned this Dec 21, 2021
@Jag96 Jag96 added the Reviewing Has a PR in review label Dec 21, 2021
@botify botify closed this as completed Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants