Deploy Checklist: New Expensify 2021-12-06

[OSBotify]

Release Version: 1.1.18-3
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Make login form accessible to Password Managers #5275

  • QA
  • Accessibility

• Fix: input alignment & error border for input #5805

  • QA
  • Accessibility

• Added Workspace Menu #5921

  • QA
  • Accessibility

• Fix: navigation to report screen from the SideModals #6207

  • QA
  • Accessibility

• Improve VBA logic #6230

  • QA
  • Accessibility

• [PlaidLink OAuth] Add web redirect_uri to /bank-accounts page #6259

  • QA
  • Accessibility

• Fix Search - Arrow navigation on search stops working #6272

  • QA
  • Accessibility

• Added ellipses for long attachment names #6294

  • QA
  • Accessibility

• Fixed "Message being edited is cancelled on pressing any key"… #6367

  • QA
  • Accessibility

• Fix white space around top and bottom edges of extra long images #6384

  • QA
  • Accessibility

• Mobile Web Safari: Adds auto scroll back - Issue 5894 #6413

  • QA
  • Accessibility

• Added attachment download loading indicator #6455

  • QA
  • Accessibility

• Fix blank screen when exiting the Onfido page in IOU flow #6461

  • QA
  • Accessibility

• Fix IOU EnablePayment route #6469

  • QA
  • Accessibility

• Add splash screen related logs #6476

  • QA
  • Accessibility

• Updated header text in test transaction step of VBA flow #6477

  • QA
  • Accessibility

• changed logic to use 2 decimals instead of 3 #6499

  • QA
  • Accessibility

• Fix web app not recognising device being online on chromebook connected via instant tethering #6500

  • QA
  • Accessibility

• add show password toggle to secureTextInput #6501

  • QA
  • Accessibility

• Block Enter key bubbling to the composer, on selecting LHN row via Enter #6515

  • QA
  • Accessibility

• Revert "Supports big screens mobile devices for popover menu" #6523

  • QA
  • Accessibility

• Fix draft value not displaying in datepicker #6524

  • QA
  • Accessibility

• Fix infinite loop in withFullPolicy HOC #6531

  • QA
  • Accessibility

• 6326: fix bug reported at #6518 #6535

  • QA
  • Accessibility

• [NOQA] Fix broken link to app structure section of readme #6536

  • QA
  • Accessibility

• [No QA] Rename Button and Text components to ExpensifyButton and ExpensifyText #6538

  • QA
  • Accessibility

• Corrected Cannot Remove Yourself banner shown again and again problem while inviting new member #6542

  • QA
  • Accessibility

• Fix: scroll issue for workspace pages #6543

  • QA
  • Accessibility

• Fix: search page order #6544

  • QA
  • Accessibility

• Disable submit button if Paypal username is unchanged #6545

  • QA
  • Accessibility

• Revert "Remove div usage in Onfido Web" #6548

  • QA
  • Accessibility

• [No QA] Update podfile for react-native-netinfo #6550

  • QA
  • Accessibility

• Allow scrolling for Report Group Details Page #6555

  • QA
  • Accessibility

• fix: Remaining pages for workspace #6557

  • QA
  • Accessibility

• iPhoneX SafeArea regression fix #6559

  • QA
  • Accessibility

• Fix italic-bold font difference #6561

  • QA
  • Accessibility

• [No QA] Fixed ExpensifyText import for Workspace #6576

  • QA
  • Accessibility

• [CP STAGING] Fix redirect_uri for Plaid web #6578

  • QA
  • Accessibility

• Updating react-native-render-html version #6582

  • QA
  • Accessibility

• change pronoun input margin to value for grouped form elements #6586

  • QA
  • Accessibility

• Added properties to fix layout on ipad #6597

  • QA
  • Accessibility

• Fix: margin for Save button on Password page #6600

  • QA
  • Accessibility

• Make preferences page scrollable #6601

  • QA
  • Accessibility

Internal QA:

• Get parameters for Plaid link token based on platform #6411 - @sketchydroide @marcaaron

Deploy Blockers:

• Android & iOS - Manage members screen is blank  #6528
• Group Chat - Unable to create group chats #6609
• Profile - Able to update profile with emojis and symbols as First and Last name  #6610
• Workspace - Members list is empty in manage members page #6612
• [HOLD for payment ASAP] Chat - Unable to initiate chat for a user that doesn't have any messages  #6614
• Web - Settings - Pressing tab on password field won't go straight to next one #6618
• VBA - Continuous loading spinner appears after company information page #6620
• Search - Some users are not prioritized over chats or rooms #6627

cc @Expensify/applauseleads

[MelvinBot]

📣 @applausebot You have been assigned to this job by @OSBotify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[roryabraham]

Checked off a number of PRs which were already CP'd to staging and then deployed to production, and thus should not be included in this checklist. Also checked off #6536, which is listed as No QA.

[mvtglobally]

Starting QA

[isagoico]

Posting this here as well - https://expensify.slack.com/archives/C9YU7BX5M/p1638900800215400

We're currently unable to access build 1.1.18-1 on Android. Build available in Playstore is 1.1.17-7 (seems there was an issue surrounding the last deploy for 1.1.18-1)

[mvtglobally]

Regression is still in progress. Updates so far

Deploy Blockers

• Group Chat - Unable to create group chats #6609
• VBA - Continuous loading spinner appears after company information page #6620
• Search - Some users are not prioritized over chats or rooms #6627

Issues found

• [HOLD for payment 2022-01-11] Android - User prompted for permission after granting permission during download #6613
• mWeb - Text input box hidden by keypad when typing message #6621
• mWeb - Payments - "Update paypal account" CTA is not floating and hidden by keypad #6622
• iPad 6 - Login page does not show with full text and images in portrait orientation #6623
• Web - "Wrong password" message not translated to Spanish #6625
• iOS - Profile - Error message when uploading a photo using camera  #6628

Regression TCs

• Create group and User search steps are blocked by Group Chat - Unable to create group chats #6609
• Bank Account TCs are blocked by VBA - Continuous loading spinner appears after company information page #6620
• Android TCs are blocked by the missing build Deploy Checklist: New Expensify 2021-12-06 #6605 (comment)

[isagoico]

Checking off #6544 > #6627 (comment)

[marcaaron]

I think #6620 can be checked off now. Issue is resolved for me on staging when re-testing.

[roryabraham]

Looks like the fix to #6528 is being CP'd to staging in 1.1.18-3 here

[roryabraham]

So to recap where we'll ideally be after 1.1.18-3 is finished deploying:

• We should be able to retest any deploy blockers and they should all be resolved.
• These regression TC's should be unblocked:
  • Create group and User search steps
  • Bank Account TCs
• I see nothing in the Google Play Console that might indicate why the Android builds wouldn't be available. Reached out for clarification in slack. Hopefully we'll be able to get this sorted.

[mvtglobally]

Checking #5805 > #6610 (comment)
Checking #6597 >#6623 (comment)

[mvtglobally]

#6620 is resolved, we are re-testing blocked steps

[mvtglobally]

Regression is Completed
TR steps re-tested

Blocked PRs re-tested too
Checking off #6542, #6524, #6230, #6477

New issue #6640 From PR #6582. We didn't mark it as Deploy Blocker as its repro in PROD. Is it PROD PR? @roryabraham @chiragsalian let us know

#6557 (comment) - Can we check it off ?

[roryabraham]

#6557 (comment) has been reverted, so we can check it off

[mvtglobally]

@roryabraham
Only #6582 is pending now with issue #6640.
Should we consider it a blocker or we can check off and close this checklist?

[roryabraham]

What about #6528?

[roryabraham]

I think #6582 and #6640 should not be treated as blockers since email responses aren't formatted correctly on production anyways. So we can probably check off #6582 on this checklist despite the fact it didn't really pass QA cc @chiragsalian

So I think the only other question is #6528. I verified that it's fixed in iOS 1.1.18-3 but need someone to retest on Android

[mvtglobally]

@roryabraham its a pass on Android

[parasharrajat]

It seems like this Checklist is ready to deploy.

[roryabraham]