Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Group - When searching for a new user to add, user name is duplicated #8094

Closed
kbecciv opened this issue Mar 11, 2022 · 11 comments
Closed
Assignees
Labels
Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Mar 11, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify.com
  2. Sign into a valid account
  3. Tap the green "Plus" icon on the bottom right
  4. Tap "New Group"
  5. Search for any user and tap on the search suggestion

Expected Result:

The users name should appear with a green check next to it

Actual Result:

The users name appears duplicated and the search becomes highlighted with a blue outline

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.42.3

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): mailto:emilio.utest@gmail.com

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Image.from.iOS.4.MP4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Mar 11, 2022
@kbecciv kbecciv changed the title New Group - Group chat - When searching for a new user to add, user name is duplicated New Group - When searching for a new user to add, user name is duplicated Mar 11, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@NikkiWines
Copy link
Contributor

I can reproduce this on dev, looking for what might have introduce this bug now 🕵️‍♀️

@NikkiWines
Copy link
Contributor

Looks like #7530, which was it was just deployed to staging - confirming now

@NikkiWines
Copy link
Contributor

Merge commit for #7530 is 80b7467fdfc5610259b3a7be33e5f603309c4be7

Checked out the merge commit prior to it 502412163a971e14f21e8cf18ebf2a3a6af25659 and confirmed the bug wasn't present.

Screen Shot 2022-03-11 at 10 31 43

cc: @AndrewGable @parasharrajat @eVoloshchak looks like #7530 has introduced this bug.

@parasharrajat
Copy link
Member

Nope. It is not a regression. It is missed case from my PR #7986.

@NikkiWines NikkiWines added Reviewing Has a PR in review Improvement Item broken or needs improvement. Daily KSv2 and removed Hourly KSv2 labels Mar 11, 2022
@NikkiWines
Copy link
Contributor

Dropping to a daily since the fix PR has been merged

@chiragsalian
Copy link
Contributor

CP-ing the PR to staging since the issue is a deploy blocker.

@chiragsalian
Copy link
Contributor

The fix for this has been CP-d to staging. Can you retest @kbecciv.

@kbecciv
Copy link
Author

kbecciv commented Mar 14, 2022

Sure, we are going to test the CPs right now. Thank you @chiragsalian

@chiragsalian
Copy link
Contributor

Once only a staging specific issue has been resolved we can close it out so that it's not repeated again as deploy blockers for the next checklist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants