Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Checklist: New Expensify 2022-03-10 #8074

Closed
OSBotify opened this issue Mar 10, 2022 · 18 comments
Closed

Deploy Checklist: New Expensify 2022-03-10 #8074

OSBotify opened this issue Mar 10, 2022 · 18 comments
Assignees
@applausebot
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Mar 10, 2022 •
edited by ogumen
Loading

Release Version: 1.1.42-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

cc @Expensify/applauseleads
@thienlnam
Copy link
Contributor

Checked off #7873, statements don't work on staging so will need to be tested on prod. This isn't used yet

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Mar 11, 2022
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.42-3 🚀

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.42-4 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.42-4 has been deployed to staging 🎉

@mvtglobally
Copy link

Deploy Blockers
#8113
#8097
#8094
#8092

Comments
#7660 (comment) is failing
#7850 is partially blocked by #7768 on IOS, but overall PR pass, checking off
#7937 is Blocked by #8040 We will retest
#7929 is failing #7929 (comment)
#7949 (comment) - Internal QA
#8025 is blocked by #8097

Issues
#8108 discovered while testing #8017
#8107 discovered while testing #8041
#8116
#8115
#8110
#8109

@chiragsalian
Copy link
Contributor

Checking off

  1. Use more user friendly errors when choosing default fund for Wallet #7929 - The delete part of the issue is not a blocker as it happens on production as well. its currently tracked here and here
  2. make payment method preview non interactive #8025 - The basic issue of the PR has been resolved. The delete paypal part is another issue mentioned in my previous point and will be handled separately.

@mvtglobally
Copy link

mvtglobally commented Mar 14, 2022 •
edited
Loading

#8049 - checking off, I missed to checkmark
checking off #8098 & 8113 as closed
#8058 - is pass on all but Desktop
1.1.42-4 is not yet available on Desktop.

@MelvinBot MelvinBot added the Monthly KSv2 label Mar 14, 2022
@chiragsalian
Copy link
Contributor

Checking off #7949 since it was internally tested.

@mvtglobally
Copy link

#8106 is pass checking off #8094
Checking off #8097 & #8115 as its no longer a blocker

Only outstanding
#8092 - we didn't get CP yet
#7660 (comment) - Should we checkoff since original issue is in prod and no fully fixed?

@chiragsalian
Copy link
Contributor

Alright so let's check out where we stand,

  1. Fix : Android - Picture looks smaller in Preview page #7660 - Is the issue on both prod and staging? If so then can you check the item and create a follow up issue so that it can be investigated later as it doesn't need to hold off deploy. If its only on staging let me know and i'll revert the PR and check it off the checklist so that the author can work
  2. Merge TextInputWithPrefix into TextInput #7937 - i noticed this is still unchecked. There is a comment thats its blocked on #8040 but that issue was closed a couple of days back. We were unable to reproduce issue from our end so can you retest and check it off?
  3. Set up Avatars for Workspace Chats  #7852 - i've pinged some people to test.
  4. Workspace - Manage members - All the avatar icons are looking same in search screen to invite new members #8092 Looks like there is a fix in place but its not on staging. I just started CP-ing the code to staging so it should be available in all devices in about 45-60mins. I'll repost once this is ready to test.

@TomatoToaster
Copy link
Contributor

TomatoToaster commented Mar 15, 2022 •
edited
Loading

Did the internalQA and can check off #7852 as per this comment:
#7852 (comment)

@mvtglobally
Copy link

@chiragsalian

  1. Will check Fix : Android - Picture looks smaller in Preview page #7660 in PROD and update in few min.
  2. Can you check off Merge TextInputWithPrefix into TextInput #7937. I checked it off few times already, I have no idea why its not saving it. It is pass. no blockers
    Screen Shot 2022-03-15 at 2 04 29 PM
  3. Will wait for CP to validate and update

@chiragsalian
Copy link
Contributor

#8092 - Code is live on staging on version 1.1.42-6.

@chiragsalian
Copy link
Contributor

chiragsalian commented Mar 15, 2022 •
edited
Loading

Can you check off #7937. I checked it off few times already, I have no idea why its not saving it. It is pass. no blockers

Oh hah, my edits are not saving as well. Okay i'll just consider it as a pass.
Edit: nvm, looks like it got updated so its checked now.

@mvtglobally
Copy link

@chiragsalian this ship is ready

  1. Fix : Android - Picture looks smaller in Preview page #7660 repro in PROD. checking off
  2. CP is pass Workspace - Manage members - All the avatar icons are looking same in search screen to invite new members #8092 checking off

@chiragsalian
Copy link
Contributor

:shipit:

@Stutikuls
Copy link

Stutikuls commented Apr 6, 2022 •
edited
Loading

Checked all PRs and creating accessibility issues for all PRs where accessibility issue was found.
The non-applicable PRs are - #7750, #7825, #7847, #7897, #7897, #7995, #7958, #7955, #7958, #7981, #7989, #7992, #7995, #7996, #8000
Logged Issues - #8428, #8429, #8430, #8463, #8464, #8478, #8479, #8480, #8484. #8485, #8522, #8523, #8481, #8524, #8525, #8552, #8553, #8557, #8388, #8554, #8387, #8558, #8559, #8529, #8530, #8385, #8555, #8556, #8560, #8527 , #8388, #8428, #8528

@SumitDiyora
Copy link

SumitDiyora commented Apr 9, 2022 •
edited
Loading

Checked all PRs on Production / Staging and created accessibility issues for all PRs where accessibility issues were found.
The non-applicable PRs are - #8000, #8010, #8016, #8024, #8026, #8027, #8028, #8037, #8043, #8049, #8054, #8059, #8064, #8067, #8069, #8078, #8081
Logged Issues - #8465, #8392, #8418, #8506, #8509, #8546, #8392, #8465, #8395, #8393, #8400, #8578, #8579, #8402, #8580, #8465, #8392, #8398, #8432, #8392, #8575, #8408, #8577, #8393, #8395, #8435, #8432, #8419, #8384, #8383, #8385, #8392, #8408
Impossibility to verify (After client confirmation) - #8009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@applausebot applausebot

Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@MelvinBot @chiragsalian @TomatoToaster @thienlnam @applausebot @mvtglobally @OSBotify @Stutikuls @SumitDiyora