Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room details - Chair icon is missing when tap room name to view the details #8098

Closed
kavimuru opened this issue Mar 11, 2022 · 7 comments
Closed
Assignees

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch the app and log in expensifail account
  2. Tap on any room created or Open Default Room (#admins and #announce) Settings.
  3. Check chair icon

Expected Result:

Chair icon is displayed in room details

Actual Result:

Chair icon is missing in room details

Workaround:

Unknown visual

Platform:

Where is this issue occurring?

  • iOS
  • Android
  • Desktop App

Version Number: 1.1.42.3
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+0707abb@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5487271_Screenshot_20220311-114535_New_Expensify

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Mar 11, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Julesssss
Copy link
Contributor

CC @TomatoToaster

@Julesssss Julesssss added Daily KSv2 Weekly KSv2 Hourly KSv2 and removed Hourly KSv2 Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Weekly KSv2 labels Mar 11, 2022
@Julesssss
Copy link
Contributor

I believe this is due to the cherry-pick issue we had earlier this week: #8054 (comment)

Though it should have been fixed in the last hour or two as the follow-up PR was merged 😕

@francoisl
Copy link
Contributor

Oh but that was the revert because we had this weird situation where OptionsListUtils.getAvatarSources was missing, right? Shouldn't we revert the revert now basically?
I'll run some quick tests locally.

@francoisl
Copy link
Contributor

Oh, but it was already cherry-picked about an hour ago #8058 (comment). It's fixed for me on 1.1.42-4, so let's rerun this just to confirm.

@francoisl
Copy link
Contributor

Yeah this definitely looks fixed on v1.1.42-4, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants