[Pay on 5/20][$250] Adding some text just after the closing backtick ` doesn't quote the text inside the backticks - reported by @adeel0202

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any chat
2. In the chat input, enter some text inside the backticks to quote it
3. Enter some text right after the closing backtick (without any space)
4. Send the message

Expected Result:

The text inside the backticks should be quoted

Actual Result:

The text inside the backticks is not quoted

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.43-2
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

text.after.backtick.mov

Expensify/Expensify Issue URL:
Issue reported by: @adeel0202
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1647273215995929

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @jboniface (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Triggered auto assignment to @mallenexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[mallenexpensify]

Checking in Slack, I have a feeling it might be intentional https://expensify.slack.com/archives/C01GTK53T8Q/p1648484082504219?thread_ts=1647273215.995929&cid=C01GTK53T8Q

[mallenexpensify]

Got some feedback in the thread above, it doesn't appear there's a real reason we shouldn't do this so I'm moving it along

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (Exported)

[melvin-bot]

Triggered auto assignment to @Beamanator (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mallenexpensify]

Job posted https://www.upwork.com/jobs/~015a0a72eaba588d69
@adeel0202 can apply please?

[mallenexpensify]

Hired @adeel0202 as bug reporter
@Santhosh-Sellavel and @brianmuks can you please apply here https://www.upwork.com/jobs/~015a0a72eaba588d69 Thanks

[brianmuks]

@mallenexpensify Pr is ready :
Expensify/expensify-common#437

[mallenexpensify]

Hired @brianmuks in Upwork. @Beamanator is there a reason @Santhosh-Sellavel wasn't assigned to the PR to review?

[Beamanator]

@mallenexpensify yeah, @Santhosh-Sellavel wasn't automatically assigned b/c we don't have all of the automation set up in the expensify-common repo yet, and also I couldn't manually assign him b/c currently C+ can only be manually assigned in E/App repo, unless they comment on issues / PRs in those other repos. I made an internal issue to work on that / think about it here: https://github.com/Expensify/Expensify/issues/205269

[mallenexpensify]

oh... wow, that's new to me! Thanks for raising internally, sounds like something we should try to fix.
Can @Santhosh-Sellavel help in/on the PR at all? I'm planning to compensate them the full C+ price so feel free to ask for help (if it's needed/wanted)

[Beamanator]

I think it would be great for @Santhosh-Sellavel to check it out, I still can't assign him to review until he posts in the PR though :D

Also @Santhosh-Sellavel can help test the next PR in E/App which needs to be made when the expensify-common PR gets merged 👍

[Santhosh-Sellavel]

@brianmuks Any update on the Next PR

cc: @Beamanator

[Beamanator]

@brianmuks just to make sure we're all on the same page, we're expecting you to also create a PR in Expensify/App which updates the version of expensify-common so Expensify/App picks up the changes you made. Let us know if you have questions how to do that

[brianmuks]

@brianmuks just to make sure we're all on the same page, we're expecting you to also create a PR in Expensify/App which updates the version of expensify-common so Expensify/App picks up the changes you made. Let us know if you have questions how to do that

Yes I need help on what is expected in the Expensify/App PR.

[Beamanator]

@brianmuks In E/App, update package.json to have the expensify-common package point to the latest commit (which has your changes)

• Your PR will look like this: https://github.com/Expensify/App/pull/7138/files
• The commit hash you will put in package.json (and, after npm install, the commit hash will appear in package-lock.json) can be found here (the most recent commit): https://github.com/Expensify/expensify-common/commits/main

[brianmuks]

@brianmuks In E/App, update package.json to have the expensify-common package point to the latest commit (which has your changes)

• Your PR will look like this: https://github.com/Expensify/App/pull/7138/files
• The commit hash you will put in package.json (and, after npm install, the commit hash will appear in package-lock.json) can be found here (the most recent commit): https://github.com/Expensify/expensify-common/commits/main

Thanks I am on it!

[mallenexpensify]

PR is being worked on

[Beamanator]

@mallenexpensify just so you know, @brianmuks 's fix was merged & deployed to staging. It's a bit of a weird situation b/c his fix to expensify-common was merged about a week ago, then while I was having trouble testing, it was merged into E/App in this PR: #8743

As you can see on that PR, it just got deployed to staging yesterday (here: #8743 (comment))

FYI some of our automation may not work so well b/c I closed brian's latest PR because his changes to E/App were already made in another issue, but he still deserves full payment whenever the changes make it to production 👍

[mallenexpensify]

So.... @Beamanator tbc... we're waiting for #8743 to hit production, then waiting 7 days after than, right?

[Beamanator]

Yes exactly 👨‍🍳 👍 💯

[mallenexpensify]

#8743 on staging...

[mallenexpensify]

Hit staging 16 days ago, not sure what's taking so long ¯_(ツ)_/¯

[mallenexpensify]

PR is on production, updated title to pay on 5/20 if no regressions

[adeel0202]

@mallenexpensify, a friendly reminder 😄

[mallenexpensify]

@adeel0202 paid $250 for reporting. Thanks for the ping, not sure how i missed this on Friday.
@Beamanator can you confirm that @brianmuks is due $250? Assuming @Santhosh-Sellavel is the same amount for C+ as Brian too

[Beamanator]

@mallenexpensify yes I can confirm @brianmuks is due $250 and so is @Santhosh-Sellavel for C+ 👍

[mallenexpensify]

Looks like @brianmuks was already paid $250, let me know if you're not seeing Brian.
Hired @Santhosh-Sellavel , please let me know once you've accepted
https://www.upwork.com/jobs/~015a0a72eaba588d69

[Santhosh-Sellavel]

@mallenexpensify
Thanks, Accepted!

[mallenexpensify]

Paid @Santhosh-Sellavel $250, everyone should be paid now! Comment if needed.