fixed bug: Adding some text just after the closing backtick doesn't … #437
Conversation
…uote the text inside the backticks #8288
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
melvin-bot
bot
requested review from
TomatoToaster
and removed request for
a team
|
I have read the CLA Document and I hereby sign the CLA |
Done! |
brianmuks
force-pushed
the
fix-backick-with-text-surfix-breaks
branch
4 times, most recently
from
b6dd8a3
to
ad9f615
Compare
__tests__/ExpensiMark-HTML-test.js
Outdated
| expect(parser.replace(testString)).toBe(resultString); | ||
| }); | ||
|
|
||
| test('Test surfix for qoutes', () => { |
There was a problem hiding this comment.
| test('Test surfix for qoutes', () => { | |
| test('Test suffix for quotes', () => { |
__tests__/ExpensiMark-HTML-test.js
Outdated
| @@ -418,3 +418,15 @@ test('Test autolink with . before a slash', () => { | |||
| const resultString = '<a href="https://www.google.com/maps/place/Poster+Auctions+International,+Inc./@40.7384572,-73.9942151,20.17z/data=!4m13!1m7!3m6!1s0x89c259a2c5fdee77:0x1439488db9133bae!2s26+W+17th+St,+New+York,+NY+10011!3b1!8m2!3d40.7383679!4d-73.993907!3m4!1s0x89c259a2c438eb63:0x115ba65a3675338b!8m2!3d40.7384793!4d-73.9937764" target="_blank" rel="noreferrer noopener">https://www.google.com/maps/place/Poster+Auctions+International,+Inc./@40.7384572,-73.9942151,20.17z/data=!4m13!1m7!3m6!1s0x89c259a2c5fdee77:0x1439488db9133bae!2s26+W+17th+St,+New+York,+NY+10011!3b1!8m2!3d40.7383679!4d-73.993907!3m4!1s0x89c259a2c438eb63:0x115ba65a3675338b!8m2!3d40.7384793!4d-73.9937764</a>'; | |||
| expect(parser.replace(testString)).toBe(resultString); | |||
| }); | |||
|
|
|||
| test('Test prefix for qoutes', () => { | |||
There was a problem hiding this comment.
| test('Test prefix for qoutes', () => { | |
| test('Test prefix for quotes', () => { |
brianmuks
force-pushed
the
fix-backick-with-text-surfix-breaks
branch
from
907ec42
to
ad9f615
Compare
Thanks I have made the needed changes. 🙏🏾 |
__tests__/ExpensiMark-HTML-test.js
Outdated
| expect(parser.replace(testString)).toBe(resultString); | ||
| }); | ||
|
|
||
| test('Test surfix for quotes', () => { |
There was a problem hiding this comment.
Need to still fix this one then I think this LGTM
| test('Test surfix for quotes', () => { | |
| test('Test suffix for quotes', () => { |
There was a problem hiding this comment.
Need to still fix this one then I think this LGTM
Done. Sorry for the typos. I need a vs-code extension for spell check 😃 .
There was a problem hiding this comment.
Lol I would like that extension too 😆
brianmuks
force-pushed
the
fix-backick-with-text-surfix-breaks
branch
from
7b8afe5
to
ad9f615
Compare
|
Ahh actually sorry @brianmuks, we can't merge your PR because your commits are unsigned. That's my bad on not catching that earlier! Could you follow the instructions here: https://github.com/Expensify/App/blob/main/CONTRIBUTING.md and open a new PR with these changes. |
Thanks. I will do just that. |
brianmuks
force-pushed
the
fix-backick-with-text-surfix-breaks
branch
from
725e209
to
ad9f615
Compare
brianmuks
force-pushed
the
fix-backick-with-text-surfix-breaks
branch
9 times, most recently
from
de03c87
to
ad9f615
Compare
@TomatoToaster new PR with amends is ready : |
…quote the text inside the backticks #8288
TAG_REVIEWER will you please review this?
[Explanation of the change or anything fishy that is going on]
Modified the regex to handle quotes with text as prefix or suffix :
expensify-common/lib/ExpensiMark.js
Line 52 in f77bb47
Fixed Issues
Expensify/App#8288 (comment)
Tests
What unit/integration tests cover your change? What autoQA tests cover your change?
What tests did you perform that validates your changed worked?
I tried submitting the text below from report compose:
"`a`"a and a"`b"QA
Mostly just from compose and edit the submitted text.