Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[High]: Chrome+Jaws : Screen reader: Role and label are not defined for "download" control. #8633

Closed
SumitDiyora opened this issue Apr 13, 2022 · 1 comment

Comments

@SumitDiyora
Copy link

SumitDiyora commented Apr 13, 2022

Action Performed:

  1. Using Chrome+JAWS, open URL: staging.new.expensify.com
  2. Navigate to Settings > Any chat and activate any attachments.
  3. Navigate to the "download" control using the screen reader.
  4. Observe the screen reader announcement.

Expected Result:

When a role is defined appropriately for the interactive element, the screen reader user will interact with the element effectively.

Actual Result:

Role is not defined for the "download". interactive element. This made it difficult for screen reader users to access the functionality associated with it. Additionally, the label is not defined for the mentioned interactive element in the source code of the page.

HTML:
<div tabindex="0" class="css-1dbjc4n r-1awozwy r-1loqt21 r-1777fci r-1otgn73 r-1i6wzkk r-lrvibr" style="height: 40px; margin-right: 8px; transition-duration: 0s; width: 40px;"><svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 20 20" width="20" height="20" fill="#C6C9CA"><path d="M9.6 13.2c.2.2.6.2.9 0l4.9-5c.2-.2.2-.6 0-.9l-.9-.9c-.2-.2-.6-.2-.9 0l-2.4 2.4v-7c0-.4-.2-.6-.6-.6H9.4c-.4 0-.6.3-.6.7V9L6.4 6.5c-.2-.2-.6-.2-.9 0l-.9.9c-.2.2-.2.6 0 .8l5 5zM18.1 13.8h-1.2c-.4 0-.6.2-.6.6v1.9H3.8v-1.9c0-.4-.2-.6-.6-.6H1.9c-.4 0-.6.2-.6.6v3.8c0 .4.2.6.6.6h16.3c.4 0 .6-.2.6-.6v-3.8c0-.4-.3-.6-.7-.6z"></path></svg></div>

Other Occurrence:
Same issue repro on PR #8238 , #8760, #9044, #9212, #9312

Workaround:

Yes

Area issue was found in:

All pages of the Expensify application were a "download" icon button is appearing.

Failed WCAG checkpoints

4.1.2, 1.1.1

User impact:

Screen reader users will not be made aware that these elements are buttons.

Suggested resolution:

Ensure that all the page functionality is available for all users irrespective of the device being used.
Apply the following changes:

  • Specify role="button" for the <div> element containing the "download" control.
  • Provide aria-label value such as "download" for the <div> element containing the "download" control.

HTML:
<div tabindex="0" role="button" aria-label="download" class="css-1dbjc4n r-1awozwy r-1loqt21 r-1777fci r-1otgn73 r-1i6wzkk r-lrvibr" style="height: 40px; margin-right: 8px; transition-duration: 0s; width: 40px;"><svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 20 20" width="20" height="20" fill="#C6C9CA"><path d="M9.6 13.2c.2.2.6.2.9 0l4.9-5c.2-.2.2-.6 0-.9l-.9-.9c-.2-.2-.6-.2-.9 0l-2.4 2.4v-7c0-.4-.2-.6-.6-.6H9.4c-.4 0-.6.3-.6.7V9L6.4 6.5c-.2-.2-.6-.2-.9 0l-.9.9c-.2.2-.2.6 0 .8l5 5zM18.1 13.8h-1.2c-.4 0-.6.2-.6.6v1.9H3.8v-1.9c0-.4-.2-.6-.6-.6H1.9c-.4 0-.6.2-.6.6v3.8c0 .4.2.6.6.6h16.3c.4 0 .6-.2.6-.6v-3.8c0-.4-.3-.6-.7-.6z"></path></svg></div>

Platform:

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.49-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
Reference link: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/button_role
Issue reported by: Sumit

#8223_role and label are not defined for controls

@melvin-bot
Copy link

melvin-bot bot commented Jul 1, 2022

@SumitDiyora, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant