Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Checklist: New Expensify 2022-06-06 #9326

Closed
47 tasks done
yuwenmemon opened this issue Jun 6, 2022 · 10 comments
Closed
47 tasks done

Deploy Checklist: New Expensify 2022-06-06 #9326

yuwenmemon opened this issue Jun 6, 2022 · 10 comments
Assignees
@applausebot
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@yuwenmemon
Copy link
Contributor

yuwenmemon commented Jun 6, 2022 •
edited
Loading

Release Version: 1.1.73-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jun 7, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Jun 7, 2022

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.73-0 🚀

@OSBotify
Copy link
Contributor

OSBotify commented Jun 7, 2022

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.73-1 🚀

@OSBotify
Copy link
Contributor

OSBotify commented Jun 7, 2022

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.73-1 has been deployed to staging 🎉

@OSBotify
Copy link
Contributor

OSBotify commented Jun 7, 2022

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.73-2 🚀

@OSBotify
Copy link
Contributor

OSBotify commented Jun 7, 2022

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.73-2 has been deployed to staging 🎉

@mvtglobally
Copy link

@yuwenmemon Regression is completed. We are almost good to 🚀

PR is failing #9064 (comment)
PR #9202 is failing due to #9340 Since its a new feature, should we check it off?

Issues logged
#9333
#9338
#9339
#9340
#9341
#9342

@yuwenmemon
Copy link
Contributor Author

Looks like #9064 (comment) has a fix, but @mountiny says it's not a deploy blocker so feel free to check it off.

@yuwenmemon
Copy link
Contributor Author

PR #9202 is failing due to #9340 Since its a new feature, should we check it off?

Yeah, talked with @amyevans - she's looking into it but we agree that we can move forward with the deploy so I'm checking it off

@yuwenmemon
Copy link
Contributor Author

:shipit:

@SumitDiyora
Copy link

Checked all PRs on Production / Staging and created accessibility issues for all PRs where accessibility issues were found.
The non-applicable PRs are - #8498, #8819, #8855, #9120, #9140, #9219, #9269, #9295, #9299, #9309
Logged Issues - #8433, #8434, #8621, #8557, #8435, #8624, #8395, #8624, #8555, #8527, #8407, #8406, #8392, #8419, #8393, #8398, #8400, #8624, #8506, #8388, #8434, #8433, #8703, #8433, #8651, #8624, #8478, #8654, #8633, #8618, #8651, #8480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@applausebot applausebot

Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@yuwenmemon @applausebot @mvtglobally @OSBotify @SumitDiyora