Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD] [$250] Android - remove "(archived)" that shows up in the DM row after deleting a workspace member #8643

Closed
kavimuru opened this issue Apr 14, 2022 · 15 comments
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@kavimuru
Copy link

kavimuru commented Apr 14, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


We found this issue when executing #8437

Action Performed:

  1. Launch the app
  2. Create a new workspace from an account that's on the policyExpenseChat beta (e.g @expensifail.com)
  3. Add a new member to the workspace via Manage Members > Invite
  4. Log-in as the member and send a couple of messages in the member's workspace chat
  5. Log back in again to the admin account and remove the member from the workspace via Manage Members > Remove
  6. Go back to LHN

Expected Result:

Chat in the LHN displayed without "Archived" after deleting a member. We compared with the PR #8437 screenshot attached

Actual Result:

Chat in the LHN displayed with "Archived" after deleting a member

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.55.0
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5532932_LHN

Upwork job link: https://www.upwork.com/jobs/~01696c42f472066bd6
Issue reported by:
Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Apr 14, 2022

Triggered auto assignment to @timszot (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@timszot timszot removed their assignment Apr 14, 2022
@timszot timszot added the External Added to denote the issue can be worked on by a contributor label Apr 14, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 14, 2022

Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@michaelhaxhiu michaelhaxhiu changed the title Android- Chat in the LHN displayed with "Archived" after deleting a member Android - remove "(archived)" that shows up in the DM row after deleting a workspace member Apr 15, 2022
@melvin-bot melvin-bot bot added the Overdue label Apr 18, 2022
@michaelhaxhiu
Copy link
Contributor

Sorry for delay! Upwork job is posted - https://www.upwork.com/jobs/~01696c42f472066bd6

@melvin-bot
Copy link

melvin-bot bot commented Apr 21, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 21, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 21, 2022

Triggered auto assignment to @Beamanator (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot changed the title Android - remove "(archived)" that shows up in the DM row after deleting a workspace member [$250] Android - remove "(archived)" that shows up in the DM row after deleting a workspace member Apr 21, 2022
@rushatgabhane
Copy link
Member

Sorry, I can't help here. I'm gonna unassign myself because I have school stuff going on 📚

@rushatgabhane rushatgabhane removed their assignment Apr 24, 2022
@Beamanator Beamanator removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 25, 2022
@Beamanator
Copy link
Contributor

Removing Help Wanted for now b/c I believe this behavior is expected, when looking at the PR that added (archived) here: #8447

@Beamanator
Copy link
Contributor

@kavimuru can you please mention who reported this issue in the OP? Also in the screenshots you posted, it would be nice if you could clarify that the first one is from the QA steps in this PR: #8437 and the second screenshot is what you're actually seeing :D

@Beamanator Beamanator changed the title [$250] Android - remove "(archived)" that shows up in the DM row after deleting a workspace member [HOLD] [$250] Android - remove "(archived)" that shows up in the DM row after deleting a workspace member Apr 25, 2022
@Beamanator
Copy link
Contributor

Putting on hold to confirm if this is a bug or not

@TomatoToaster
Copy link
Contributor

Cross posting here in this issue from here to confirm, but yes this is not a bug and is intended behavior.

If this ever happens for a non-workspace chat, it is definitely a bug.

@michaelhaxhiu
Copy link
Contributor

@Beamanator @TomatoToaster So do we want to make this a feature request (since it's not a bug), or close it?

@TomatoToaster
Copy link
Contributor

Oh yes sorry let's close it. I'm realizing I didn't close with comment.

@TomatoToaster
Copy link
Contributor

This behavior should be fixed and universal (work same on iOS and android) with this PR: #8751. If that's not the case when this PR is being QA'ed, then we could reopen this to make sure it works the same in iOS and android.

@michaelhaxhiu
Copy link
Contributor

I'll check back on this on Friday. Let's leave closed till then

@Beamanator
Copy link
Contributor

Awesome thanks for closing this out and confirming it's expected @TomatoToaster 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants