Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2022-04-13 #8631

Closed
25 tasks done
Julesssss opened this issue Apr 13, 2022 · 16 comments
Closed
25 tasks done

Deploy Checklist: New Expensify 2022-04-13 #8631

Julesssss opened this issue Apr 13, 2022 · 16 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@Julesssss
Copy link
Contributor

Julesssss commented Apr 13, 2022

Release Version: 1.1.55-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Apr 13, 2022
@OSBotify
Copy link
Contributor

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.55-1 🚀

@mvtglobally
Copy link

@Julesssss Cna you pls check if IOS deployed successfully? We still dont have the build

@Stutikuls
Copy link

Stutikuls commented Apr 18, 2022

Checked all PRs and created accessibility issues for all PRs where accessibility issue were found.
The non-applicable PRs are - #8446, #8472
logged Issues - #8463, #8671, #8481, #8624, #8616, #8670, #8619, #8522, #8605, #8619, #8624, #8480, #8480, #8624, #8617, #8385 , #8463, #8464, #8620, #8669, #8618, #8385, #8668, #8667, #8522, #8479, #8621, #8557, #8621, #8667

@mvtglobally
Copy link

@yuwenmemon happy Monday. Let us know if you have any update on the IOS build readiness so we can resume the testing

@melvin-bot melvin-bot bot added the Monthly KSv2 label Apr 18, 2022
@yuwenmemon
Copy link
Contributor

@mvtglobally See https://expensify.slack.com/archives/C9YU7BX5M/p1650314731202989 I think we should be good to resume?

@mvtglobally
Copy link

thanks @yuwenmemon We are working on it. Will update all results in the morning

@Julesssss
Copy link
Contributor Author

@Julesssss Cna you pls check if IOS deployed successfully? We still dont have the build

Sorry @mvtglobally I was in hospital overnight and didn't see this.

@OSBotify
Copy link
Contributor

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.55-2 🚀

@OSBotify
Copy link
Contributor

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.55-2 has been deployed to staging 🎉

@yuwenmemon
Copy link
Contributor

@mvtglobally how's everything going? I see that no QA items have been checked off just yet...

@mvtglobally
Copy link

@yuwenmemon ,
Regression is completed. We are validating last 2 CPs right now

@yuwenmemon
Copy link
Contributor

Awesome, thanks!

@mvtglobally
Copy link

@yuwenmemon
#8512 is blocked due to #8534 Its repro in PROD, not sure if we can check it off as this is BETA feature.

Issues logged
#8643
#8640
#8641
#8644
#8646
#8648
#8660
#8661
#8690

@yuwenmemon
Copy link
Contributor

@mvtglobally I think it's fine to check off, since yeah, it is a beta feature. I'll give a heads up about the blocker though.

@mvtglobally
Copy link

@yuwenmemon CPs are pass. Checking off. Looks like we are good to 🚀

@yuwenmemon
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Development

No branches or pull requests

6 participants