[Workspace Chats] Web - Chat- Archive reason not immediately available for workspace chats

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

We found this issue when executing #8437
Original issue isn't fixed https://github.com/Expensify/Expensify/issues/204497

Action Performed:

1. Go to https://staging.new.expensify.com
2. Create a new workspace from an account that's on the policyExpenseChat beta (e.g @expensifail.com)
3. Add a new member to the workspace via Manage Members > Invite
4. Log-in as the member and send a couple of messages in the member's workspace chat
5. Log back in again to the admin account and remove the member from the workspace via Manage Members > Remove
6. Go back to LHN and open .
7. Click back into the workspace chat.

Expected Result:

Textbox is appeared after back into the workspace chat

Actual Result:

Textbox is appeared after refresh the page

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.55.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): applausetester+41322abb@applause.expensifail.com

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5532904_Screen_Recording_20220413-173202_Chrome.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[michaelhaxhiu]

@yuwenmemon just to confirm, do you think this issue should be internal or external?

[yuwenmemon]

This can be external!

[melvin-bot]

Triggered auto assignment to @mallenexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[mallenexpensify]

Posted! https://www.upwork.com/jobs/~0161ef6695919d8c97

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

[melvin-bot]

Triggered auto assignment to @NikkiWines (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[wildan-m]

@kbecciv How should it behave when a member is deleted from the workspace?

(1) Should it keep the old chat but hide the textbox or (2) delete the chat archive completely.

I can't reproduce the above issue exactly.
What happened to me is similar with this issue #8470

It can only be refreshed after logout and re-login and the chat entries are completely gone.

[mallenexpensify]

Doubled price to $500
https://www.upwork.com/jobs/~0161ef6695919d8c97

@parasharrajat , can you help with @wildanmuhlis2 's question above?

[parasharrajat]

@wildan-m do this.

1. enable the beta as you did from Permissions.js. BTW they should be already enabled on dev server.

function canUsePolicyRooms(betas) {
    return true || _.contains(betas, CONST.BETAS.POLICY_ROOMS) || _.contains(betas, CONST.BETAS.ALL);
}

/**
 * @param {Array<String>} betas
 * @returns {Boolean}
 */
function canUsePolicyExpenseChat(betas) {
    return true || _.contains(betas, CONST.BETAS.POLICY_EXPENSE_CHAT) || canUseAllBetas(betas);
}

2. Now Go to the Green Plus icon for the LHN (chat list).
3. See if it gives an option to create a room (new Room).
4. Create a Room.

Then follow the steps from the issue description.

[trjExpensify]

^^ A policyExpenseChat gets created automatically for each member of a workspace, so you don't need to create a New room to test this.

[wildan-m]

@parasharrajat after overriding canUsePolicyRooms , I can create a custom room for a specific workspace, but it's different from the chat room shown on @mvtglobally's screen. Her screen doesn't have a hashtag prefix.

My screen after create custom room:

Also, this custom room behave differently when member access revoked. It will show the textbox but pointed to Unavailable Workspace

[wildan-m]

^^ A policyExpenseChat gets created automatically for each member of a workspace, so you don't need to create a New room to test this.

@trjExpensify Does it only work for account @expensifail.com? I use @gmail.com for test account

[trjExpensify]

Not that I'm aware, just requires the policyExpenseChat beta. Did you CMD+K search for a member on the workspace to find the workspace chat? (E.g "wildevemail@gmail.com" before you removed that user)

[parasharrajat]

Oh, yeah. Sorry, I didn't notice this. I wasn't aware of that feature. I can't find the same.

[TomatoToaster]

I'm just being aware of this issue now, but I think this is better as an internal issue since users outside of the policyExpenseChat beta will never be able to see Workspace Chats (different from policyRooms). We filter out policyExpenseChats at the API level and so there's nothing you can do in the client that would let you access them.

[wildan-m]

@TomatoToaster thanks for your clarification, I'll move to other issues then

[TomatoToaster]

Actually in testing this right now, it seems to be fixed! 🎉

Here's a screen recording testing this on production:

Screen.Recording.2022-05-02.at.11.41.16.AM.mov

I think this may have been inadvertently fixed when other PRs relating to the archive reason were merged since this issue was opened.

I'll wait for @trjExpensify or QA to confirm before closing this out, but I think no PR is necessary for this one.

[trjExpensify]

Looks like we're good here!

[trjExpensify]

👋 @TomatoToaster - when I removed the member from the workspace, it still took navigating away and back to the workspace chat for the archiveReason to update:

[JmillsExpensify]

Should we create a new issue for this one @TomatoToaster or keep using the old issue?

[TomatoToaster]

This issues fine, I can look into this one.

[TomatoToaster]

Got a PR for this one, should be in review soon.