Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mWeb - Payments - "Add to payment method" blinks when user accesses the menu #8646

Closed
kbecciv opened this issue Apr 14, 2022 · 3 comments
Closed
Assignees
Labels
Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Apr 14, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Access www.staging.new.expensify.com
  2. Log into any valid account
  3. Tap on the "Profile" icon on the top right
  4. Tap on "Payments" option

Expected Result:

The user expects that when the page loads, there is no flickering or delayed loading

Actual Result:

The "Add Payment method" text is initially "Blocked" before turning black as it should be

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Mobile Web

Version Number: 1.1.55.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): n/a

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5533152_Add_Payment_is_flickering.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Apr 14, 2022

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@neil-marcellini
Copy link
Contributor

We gray out and disable adding payments when the payment methods are loading, but I can't see why we would do that, so I'll ask about it in Slack.

@neil-marcellini
Copy link
Contributor

This could be external, but I'm going to take it for myself. I think it would be worth fixing, but I'll wait for more feedback before I start working on it.

@neil-marcellini neil-marcellini added Weekly KSv2 Improvement Item broken or needs improvement. and removed Daily KSv2 labels Apr 14, 2022
@neil-marcellini neil-marcellini added the Reviewing Has a PR in review label Apr 19, 2022
@melvin-bot melvin-bot bot closed this as completed Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

2 participants