Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Able to create two workspaces at the same time #8660

Closed
kbecciv opened this issue Apr 16, 2022 · 6 comments
Closed

Web - Able to create two workspaces at the same time #8660

kbecciv opened this issue Apr 16, 2022 · 6 comments
Assignees
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement.

Comments

@kbecciv
Copy link

kbecciv commented Apr 16, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the website https://staging.new.expensify.com
    in browser
  2. Click on the action selection button (New chat, New group.....) and leave this window open
  3. Open the website https://staging.new.expensify.com
    in the browser on the phone
  4. Click on the action selection button (New chat, New group.....) and create "New workspace"
    5.Go to the window opened in step 2 and click "New workspace"

Expected Result:

After adding a workspace on the phone, the add button should disappear and it is impossible to create a second workspace.

Actual Result:

There is no update of changes, and the add workspace button is active, after which you can create a second workspace.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.55.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): n/a

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5535036_55.mp4
Bug5535036_video_2022-04-16_11-41-41.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Apr 16, 2022

Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Apr 19, 2022

@cead22 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@cead22
Copy link
Contributor

cead22 commented Apr 19, 2022

Will check in #product what we want here

@melvin-bot melvin-bot bot removed the Overdue label Apr 19, 2022
@cead22 cead22 added the Improvement Item broken or needs improvement. label Apr 19, 2022
@cead22
Copy link
Contributor

cead22 commented Apr 19, 2022

Me and @roryabraham agreed we should start by implementing a check on the backend to prevent this, so we should solve this internally, but there's clear repro steps, so labeling with Demolition

@melvin-bot
Copy link

melvin-bot bot commented Apr 19, 2022

Triggered auto assignment to @roryabraham (Demolition), see https://stackoverflow.com/c/expensify/questions/8099 for more details.

@cead22 cead22 removed their assignment Apr 19, 2022
@iwiznia
Copy link
Contributor

iwiznia commented Apr 20, 2022

I think this problem will be solved when we finish all the offline conversations (as the event when we create a policy would be sent to all clients and they would know to hide the button to create a new workspace).
I think we should do nothing for now since this is probably an edge case very few real users face.

@iwiznia iwiznia closed this as completed Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement.
Projects
None yet
Development

No branches or pull requests

4 participants