Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS/Android - Payments - Google search doesn't work in Debit card Information page #8797

Closed
kbecciv opened this issue Apr 27, 2022 · 21 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@kbecciv
Copy link

kbecciv commented Apr 27, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigate to staging
  2. Navigate to Settings > Payments > Add payment method > Debit card
  3. Search for an address

Expected Result:

Google search works in Debit card Information page

Actual Result:

Google search doesn't work in Debit card Information page

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS
  • Android

Version Number: 1.1.57.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screenshot_20220427-091959_New Expensify

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Apr 27, 2022

Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kbecciv
Copy link
Author

kbecciv commented Apr 27, 2022

@Julesssss opened a new tickets due to request #8256

@parasharrajat
Copy link
Member

parasharrajat commented Apr 27, 2022

I see this error on Android. Looks like there are API key issues.

{
   "error_message" : "This IP, site or mobile application is not authorized to use this API key. Request received from IP address 223.178.211.57, with empty referer",
   "predictions" : [],
   "status" : "REQUEST_DENIED"
}

@Julesssss
Copy link
Contributor

Nice find. Keeping this internal while we figure out if the solution is to modify the URL, or make changes in the Google console: https://stackoverflow.com/questions/21933247/this-ip-site-or-mobile-application-is-not-authorized-to-use-this-api-key

@Julesssss
Copy link
Contributor

Julesssss commented Apr 27, 2022

Okay, seems to be fixed in the library that we previously forked: FaridSafi/react-native-google-places-autocomplete#170 -- though that was from 2017! So possily different

@Julesssss Julesssss added Internal Requires API changes or must be handled by Expensify staff Weekly KSv2 and removed Daily KSv2 labels Apr 29, 2022
@melvin-bot melvin-bot bot added the Overdue label May 9, 2022
@Julesssss
Copy link
Contributor

No update, keeping assigned

@Julesssss
Copy link
Contributor

Still on hold due to higher priority issues

@melvin-bot melvin-bot bot removed the Overdue label Jun 21, 2022
@melvin-bot melvin-bot bot added the Overdue label Jul 25, 2022
@Julesssss
Copy link
Contributor

No change

@melvin-bot melvin-bot bot removed the Overdue label Jul 27, 2022
@melvin-bot melvin-bot bot added the Overdue label Aug 29, 2022
@Julesssss
Copy link
Contributor

Still held

@melvin-bot melvin-bot bot removed the Overdue label Aug 30, 2022
@Julesssss
Copy link
Contributor

No change here.

@melvin-bot melvin-bot bot removed the Overdue label Oct 4, 2022
@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@puneetlath puneetlath added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Nov 2, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 2, 2022

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 labels Nov 2, 2022
@puneetlath
Copy link
Contributor

@Julesssss I removed and re-added the Bug label to get a BZ team member assigned to help move this forward.

@MitchExpensify
Copy link
Contributor

Can this be made external? I'm unsure

@parasharrajat
Copy link
Member

Nope, #8797 (comment).

Someone from the internal team needs to relax some restrictions on the Google console.

@melvin-bot melvin-bot bot added the Overdue label Nov 7, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 8, 2022

@Julesssss, @MitchExpensify Eep! 4 days overdue now. Issues have feelings too...

@Julesssss Julesssss added Weekly KSv2 and removed Daily KSv2 labels Nov 8, 2022
@melvin-bot melvin-bot bot removed the Overdue label Nov 8, 2022
@Julesssss
Copy link
Contributor

The next step will be to assign to infra for this step:

This IP, site or mobile application is not authorized to use this API key. Request received from IP address 223.178.211.57, with empty referer

@melvin-bot
Copy link

melvin-bot bot commented Nov 8, 2022

Triggered auto assignment to @flodnv (ring0), see https://stackoverflow.com/c/expensify/questions/6102 for more details.

@Julesssss
Copy link
Contributor

Hey @flodnv, we believe this error requires a change to the key we're using, or perhaps a modified permission for the key we're using. Relevant StackOverflow

@Julesssss
Copy link
Contributor

@flodnv pointed out that this is no longer occuring. @kbecciv would you mind attempting to reproduce? Thanks!

@flodnv flodnv removed the ring0 label Nov 8, 2022
@flodnv flodnv removed their assignment Nov 8, 2022
@arielgreen
Copy link
Contributor

@MitchExpensify can you update on the status of this one? If it's still reproducible, let's throw Demolition on it and get it moving forward.

@arielgreen arielgreen added Daily KSv2 and removed Weekly KSv2 labels Nov 8, 2022
@flodnv
Copy link
Contributor

flodnv commented Nov 9, 2022

@arielgreen this is not reproducible as per the comment above yours. Please reopen if you can reproduce.

@flodnv flodnv closed this as completed Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

7 participants