-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2022-09-26] [HOLD for payment 2022-09-12] [$1000] Android - Chat - Action menu doesn't open when hold on message for action #8920
Comments
Triggered auto assignment to @MariaHCD ( |
We were only able to reproduce this issue in Android. mWeb and iOS are working as expected. |
@MariaHCD Hello! No, issues found by Applause during PR or regression testing are labeled with the |
Thanks for clarifying! Able to reproduce the issue on an Android device when following the steps outlined in the OP as well as by:
|
Triggered auto assignment to @michaelhaxhiu ( |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat ( |
Job posted to upwork - https://www.upwork.com/jobs/~0128ed0cfe93e57f70 |
Triggered auto assignment to @roryabraham ( |
Doubled |
The good/bad thing is that I can't repro this issue. Am I following the right steps? If yes, we can test and close this one out :) screen-20220524-092803.mp4 |
cc @kbecciv Can you try to reproduce once more on your side please? |
@michaelhaxhiu I'm still able to reproduce. After a few tries the action menu does open in another message from the conversation history. action.menu.mp4 |
@isagoico thanks for the quick assist :) |
PR was merged yesterday |
@parasharrajat It seems I frogot to upgrade RNGestureHandler version to 2.6.0 in ios/Podfile.lock, when I run command diff --git a/ios/Podfile.lock b/ios/Podfile.lock
index 6d84eedf9..9113be1cf 100644
--- a/ios/Podfile.lock
+++ b/ios/Podfile.lock
@@ -582,7 +582,7 @@ PODS:
- Firebase/Performance (= 8.8.0)
- React-Core
- RNFBApp
- - RNGestureHandler (2.5.0):
+ - RNGestureHandler (2.6.0):
- React-Core
- RNPermissions (3.6.1):
- React-Core
@@ -1000,7 +1000,7 @@ SPEC CHECKSUMS:
RNFBApp: 729c0666395b1953198dc4a1ec6deb8fbe1c302e
RNFBCrashlytics: 2061ca863e8e2fa1aae9b12477d7dfa8e88ca0f9
RNFBPerf: 389914cda4000fe0d996a752532a591132cbf3f9
- RNGestureHandler: bad495418bcbd3ab47017a38d93d290ebd406f50
+ RNGestureHandler: 920eb17f5b1e15dae6e5ed1904045f8f90e0b11e
RNPermissions: dcdb7b99796bbeda6975a6e79ad519c41b251b1c
RNReactNativeHapticFeedback: 1e3efeca9628ff9876ee7cdd9edec1b336913f8c
RNReanimated: 2cf7451318bb9cc430abeec8d67693f9cf4e039c |
Yeah, please do that. |
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.96-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2022-09-12. 🎊 |
Issue not reproducible during KI retests. (Second week) |
@b1tjoy Did you create the new PR? |
@parasharrajat Sorry for the delay, here is the new PR #10832 |
Thanks for creating the PR, looks good. |
@michaelhaxhiu It seems the Upwork job has been closed, could you please send me an offer, here is my Upwork profile. |
New job link is here - https://www.upwork.com/jobs/~01b76e13330fab254a. Invited you. @parasharrajat don't forget to accept my invite, too. |
@michaelhaxhiu Job is closed. |
Bump @michaelhaxhiu |
@michaelhaxhiu, @parasharrajat, @roryabraham, @b1tjoy Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@parasharrajat weird, I invited you to the job but I think it didn't register properly. Now I can't invite you to the job because it's closed (like you mentioned). Here's a new job link for you @parasharrajat - https://www.upwork.com/jobs/~010d259d77027c82b5 @b1tjoy has been paid ✅ |
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.1-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2022-09-26. 🎊 |
Both paid. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Optional menu should open after hold finger on message
Actual Result:
Optional menu doesn't open when hold on message for action.
Workaround:
Unknown
Platform:
Where is this issue occurring?
Version Number: 1.1.57.7
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): applausetester+0901abb@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug5561283_Screen_Recording_20220506-122855_New_Expensify.mp4
Upwork job link: https://www.upwork.com/jobs/~0128ed0cfe93e57f70
Issue reported by: Applause (Exploratory)
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: