[HOLD for payment 2022-09-26] [HOLD for payment 2022-09-12] [$1000] Android - Chat - Action menu doesn't open when hold on message for action

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch the app
2. Log in with expensifail account
3. Tap on any user
4. Star the conversation with him/her
5. Send the message
6. After message sent - hold your finger on it until the optional menu opens.

Expected Result:

Optional menu should open after hold finger on message

Actual Result:

Optional menu doesn't open when hold on message for action.

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Android

Version Number: 1.1.57.7

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): applausetester+0901abb@applause.expensifail.com

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5561283_Screen_Recording_20220506-122855_New_Expensify.mp4

Upwork job link: https://www.upwork.com/jobs/~0128ed0cfe93e57f70

Issue reported by: Applause (Exploratory)

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[isagoico]

We were only able to reproduce this issue in Android. mWeb and iOS are working as expected.

[MariaHCD]

@kbecciv @isagoico Shouldn't this issue have the AutoAssignerTriage label added first instead of the Engineering label?

[isagoico]

@MariaHCD Hello! No, issues found by Applause during PR or regression testing are labeled with the engineering label directly when creating.

[MariaHCD]

Thanks for clarifying! Able to reproduce the issue on an Android device when following the steps outlined in the OP as well as by:

1. Opening a chat with a user
2. Sending the app into the background
3. Bringing the app back into the foreground
4. Tapping and holding on a message and verifying that no action menu appears.

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

[michaelhaxhiu]

Job posted to upwork - https://www.upwork.com/jobs/~0128ed0cfe93e57f70

[melvin-bot]

Triggered auto assignment to @roryabraham (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[michaelhaxhiu]

Doubled

[rushatgabhane]

The good/bad thing is that I can't repro this issue.
v1.1.64-0 (Pixel 6, Android 12)

Am I following the right steps? If yes, we can test and close this one out :)

screen-20220524-092803.mp4

[michaelhaxhiu]

cc @kbecciv Can you try to reproduce once more on your side please?

[isagoico]

@michaelhaxhiu I'm still able to reproduce. After a few tries the action menu does open in another message from the conversation history.

action.menu.mp4

[michaelhaxhiu]

@isagoico thanks for the quick assist :)

[roryabraham]

PR was merged yesterday

[b1tjoy]

@parasharrajat It seems I frogot to upgrade RNGestureHandler version to 2.6.0 in ios/Podfile.lock, when I run command cd ios; pod install, file ios/Podfile.lock will be updated, should I create a PR to upgrade it?

diff --git a/ios/Podfile.lock b/ios/Podfile.lock
index 6d84eedf9..9113be1cf 100644
--- a/ios/Podfile.lock
+++ b/ios/Podfile.lock
@@ -582,7 +582,7 @@ PODS:
     - Firebase/Performance (= 8.8.0)
     - React-Core
     - RNFBApp
-  - RNGestureHandler (2.5.0):
+  - RNGestureHandler (2.6.0):
     - React-Core
   - RNPermissions (3.6.1):
     - React-Core
@@ -1000,7 +1000,7 @@ SPEC CHECKSUMS:
   RNFBApp: 729c0666395b1953198dc4a1ec6deb8fbe1c302e
   RNFBCrashlytics: 2061ca863e8e2fa1aae9b12477d7dfa8e88ca0f9
   RNFBPerf: 389914cda4000fe0d996a752532a591132cbf3f9
-  RNGestureHandler: bad495418bcbd3ab47017a38d93d290ebd406f50
+  RNGestureHandler: 920eb17f5b1e15dae6e5ed1904045f8f90e0b11e
   RNPermissions: dcdb7b99796bbeda6975a6e79ad519c41b251b1c
   RNReactNativeHapticFeedback: 1e3efeca9628ff9876ee7cdd9edec1b336913f8c
   RNReanimated: 2cf7451318bb9cc430abeec8d67693f9cf4e039c

[parasharrajat]

Yeah, please do that.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.96-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Upgrade RNGH to 2.6.0 to fix default max distance for long press on Android #10717

If no regressions arise, payment will be issued on 2022-09-12. 🎊

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[parasharrajat]

@b1tjoy Did you create the new PR?

[b1tjoy]

@b1tjoy Did you create the new PR?

@parasharrajat Sorry for the delay, here is the new PR #10832

[parasharrajat]

Thanks for creating the PR, looks good.

[b1tjoy]

@michaelhaxhiu It seems the Upwork job has been closed, could you please send me an offer, here is my Upwork profile.

[michaelhaxhiu]

New job link is here - https://www.upwork.com/jobs/~01b76e13330fab254a. Invited you.

@parasharrajat don't forget to accept my invite, too.

[parasharrajat]

@michaelhaxhiu Job is closed.

[parasharrajat]

Bump @michaelhaxhiu

[melvin-bot]

@michaelhaxhiu, @parasharrajat, @roryabraham, @b1tjoy Whoops! This issue is 2 days overdue. Let's get this updated quick!

[michaelhaxhiu]

@parasharrajat weird, I invited you to the job but I think it didn't register properly. Now I can't invite you to the job because it's closed (like you mentioned).

Here's a new job link for you @parasharrajat - https://www.upwork.com/jobs/~010d259d77027c82b5

@b1tjoy has been paid ✅

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.1-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] upgrade RNGestureHandler to 2.6.0 in Podfile.lock #10832

If no regressions arise, payment will be issued on 2022-09-26. 🎊

[michaelhaxhiu]

Both paid.