Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD] [$250] Web - Firefox- Search box - New chat selected through the search box does not open correct chat conversation #9342

Closed
kbecciv opened this issue Jun 7, 2022 · 24 comments

Comments

@kbecciv
Copy link

kbecciv commented Jun 7, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Log in to any account
  3. On the search box, search any user and select him/her
  4. Repeat the step 3- On the search box, search any user and select him/her

Expected Result:

You must navigate to the chat conversation with the selected user

Actual Result:

New chat selected through the search box does not open correct chat conversation

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web/Firefox

Version Number: 1.1.73.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5600486_Recording__720.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause- internal Team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Jun 7, 2022

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@danieldoglas
Copy link
Contributor

I could not simulate this. Tested on firefox 101.0.1 (64-bit)

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 13, 2022
@danieldoglas
Copy link
Contributor

Ok, I've tried again and could not simulate this. So I think we should close.

@kbecciv
Copy link
Author

kbecciv commented Jul 19, 2022

@danieldoglas QA team is able to reproduce this issue on version 1.1.85.2

Screen.Recording.2022-07-19.at.18.23.40.mov

@kbecciv kbecciv reopened this Jul 19, 2022
@danieldoglas
Copy link
Contributor

Can you possibly share which account you're using with me @kbecciv ? I still can't simulate that, for some reason

@kbecciv
Copy link
Author

kbecciv commented Jul 19, 2022

@danieldoglas Can you please try with credentials: yuriy.turbo+ch5@gmail.com/Aa111111

@danieldoglas
Copy link
Contributor

danieldoglas commented Jul 25, 2022

@kbecciv I've tried with those credentials and I succeeded trying to search and open all the reports available.

Can you provide the access for the account in the video? Maybe there's something specific in that user.

@danieldoglas
Copy link
Contributor

Looking through the logs in the video, something is redirecting the user to the last report, but there are no errors logged to justify it. Will need to do a step by step debugging

@kbecciv
Copy link
Author

kbecciv commented Jul 25, 2022

@danieldoglas On the video it’s HT account with 2fa, but it’s often appears on any account, for example: yuriy.turbo+ch5@gmail.com:/Aa111111

@danieldoglas
Copy link
Contributor

danieldoglas commented Jul 26, 2022

I did try with that user, moving from all open conversations to others, but was not able to simulate.

Do you think you can generate a scenario where it will happen 100% of the times? I'm not sure why I can't simulate it. @PauloGasparSv think you can test this out to see if it happens for you?

@PauloGasparSv
Copy link
Contributor

PauloGasparSv commented Jul 26, 2022

Can't reproduce it here either @danieldoglas. Also tested searching and choosing the second matching user (to see if the prob was choosing any but the first) and couldn't reproduce the error.

Firefox version: 102.0.1 (64-bit) (also tested on 98.0.1 64-bit)

@melvin-bot melvin-bot bot added the Overdue label Jul 29, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 1, 2022

@danieldoglas Huh... This is 4 days overdue. Who can take care of this?

@danieldoglas danieldoglas added Weekly KSv2 and removed Daily KSv2 labels Aug 1, 2022
@melvin-bot melvin-bot bot removed the Overdue label Aug 1, 2022
@danieldoglas
Copy link
Contributor

Changing this to weekly since we can't reproduce it. It's still on my radar.

@melvin-bot melvin-bot bot added the Overdue label Aug 10, 2022
@danieldoglas
Copy link
Contributor

Moving this one to @PauloGasparSv

@melvin-bot melvin-bot bot removed the Overdue label Aug 16, 2022
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Aug 24, 2022
@arielgreen
Copy link
Contributor

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Aug 24, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 24, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 24, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 24, 2022

Triggered auto assignment to @jasperhuangg (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot changed the title Web - Firefox- Search box - New chat selected through the search box does not open correct chat conversation [$250] Web - Firefox- Search box - New chat selected through the search box does not open correct chat conversation Aug 24, 2022
@parasharrajat
Copy link
Member

As this is a navigation issue, let's hold this and add it to navigation project on the repo.

This will be tackled with other navigation issues.

@melvin-bot
Copy link

melvin-bot bot commented Aug 24, 2022

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

@jasperhuangg jasperhuangg changed the title [$250] Web - Firefox- Search box - New chat selected through the search box does not open correct chat conversation [HOLD] [$250] Web - Firefox- Search box - New chat selected through the search box does not open correct chat conversation Aug 24, 2022
@jasperhuangg jasperhuangg added this to HOLD in Navigation Aug 24, 2022
@jasperhuangg
Copy link
Contributor

Unassigning myself for now since my plate is pretty full atm and this issue is on HOLD.

@jasperhuangg jasperhuangg removed their assignment Aug 24, 2022
@melvin-bot melvin-bot bot added the Overdue label Sep 2, 2022
@arielgreen
Copy link
Contributor

Removed Upwork job for now

@melvin-bot melvin-bot bot removed the Overdue label Sep 5, 2022
@arielgreen arielgreen removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 5, 2022
@arielgreen arielgreen removed their assignment Sep 5, 2022
@marcaaron
Copy link
Contributor

I'm closing this. It doesn't seem reproducible.

@marcaaron marcaaron closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2022
@marcaaron marcaaron removed Exported External Added to denote the issue can be worked on by a contributor Weekly KSv2 labels Sep 7, 2022
@marcaaron marcaaron moved this from HOLD to Closed w/o fix / Wontfix in Navigation Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Navigation
Closed w/o fix / Wontfix
Development

No branches or pull requests

7 participants