Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semi-large block of text stuck at the bottom of a chat #9370

Closed
mvtglobally opened this issue Jun 9, 2022 · 11 comments
Closed

Semi-large block of text stuck at the bottom of a chat #9370

mvtglobally opened this issue Jun 9, 2022 · 11 comments
Labels
Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Not a priority

Comments

@mvtglobally
Copy link

mvtglobally commented Jun 9, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Copy/pasted a semi-large block of test text into a chat and sent
  2. Followed up with few more short messages

Expected Result:

The messages to show in order

Actual Result:

The semi-large block of text is stuck at the bottom of the chat, all new chats show above it.

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Desktop App

Version Number: 1.1.73-2
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.458.mp4

semi-large block of text stuck at bottom.txt

Expensify/Expensify Issue URL:
potentially related to https://expensify.slack.com/archives/C01GTK53T8Q/p1653601453584099
and
https://github.com/Expensify/Web-Expensify/pull/33873
Issue reported by: @mallenexpensify @alex-mechler
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1654705381346799

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Jun 9, 2022

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@flodnv
Copy link
Contributor

flodnv commented Jun 9, 2022

I think this is because the large block of text will never send. Perhaps I am wrong.

@flodnv flodnv added the External Added to denote the issue can be worked on by a contributor label Jun 9, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jun 9, 2022

Triggered auto assignment to @mallenexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@alex-mechler
Copy link
Contributor

I actually think this might have to be internal. If you refresh the page, the message did send, so I think its related to the pushes failing to send, or the web api returning an error

@melvin-bot melvin-bot bot added the Overdue label Jun 13, 2022
@mallenexpensify
Copy link
Contributor

@alex-mechler , should I label internal or post somewhere to get more 👀 to confirm it needs to be internal?

@melvin-bot melvin-bot bot removed the Overdue label Jun 13, 2022
@alex-mechler
Copy link
Contributor

I'll dig a bit today to see which it is

@alex-mechler
Copy link
Contributor

Doesn't appear to be related to the size of the chunks, as I've switched chunk size down to 1k (well under the limit even if each character is taking the max size), and the push is still failing to send. Since the push itself is failing to send, its internal @mallenexpensify

@mallenexpensify mallenexpensify removed their assignment Jun 13, 2022
@mallenexpensify
Copy link
Contributor

Thanks @alex-mechler , unassigning since I/we reported and it's internal, no one is due compensation

@flodnv flodnv added Internal Requires API changes or must be handled by Expensify staff Weekly KSv2 Improvement Item broken or needs improvement. and removed External Added to denote the issue can be worked on by a contributor Daily KSv2 labels Jun 14, 2022
@melvin-bot melvin-bot bot added the Overdue label Jun 22, 2022
@flodnv flodnv removed their assignment Jun 23, 2022
@melvin-bot melvin-bot bot removed the Overdue label Jun 23, 2022
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Jul 15, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jul 15, 2022

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Jul 15, 2022
@melvin-bot melvin-bot bot closed this as completed Sep 27, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 27, 2022

@mvtglobally, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@mallenexpensify
Copy link
Contributor

Pretty sure this will be fixed once we deprecate sequence numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Not a priority
Projects
None yet
Development

No branches or pull requests

4 participants