-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/11157 Unable to save first name, last name and time zone when user is offline #11371
fix/11157 Unable to save first name, last name and time zone when user is offline #11371
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
3a93279
to
2fe0f25
Compare
@tienifr, address these suggestions -
You can any merged PR or just ask question here if you need help. |
@thesahindia I marked this PR as draft, I will request a review when done. Thanks for pointing that out. |
2ce8228
to
bcce4d3
Compare
bcce4d3
to
684c768
Compare
Updated PR and added some missed information |
I have read the CLA Document and I hereby sign the CLA |
recheck |
@thesahindia This PR is completed, please help to review. |
We just need a brief description in the details, you don't have to write about the code changes. Something like Also a suggestion, keep the commit message short and specific to the code change. |
@thesahindia Thanks for pointing that out. I just resolved your comment, please help to check again |
@tienifr, you haven't updated the details. Please address it. |
@thesahindia Sorry about that, I just updated the details. Please help to check again. Thanks |
The code looks good and works correctly.
|
Feel free to review the PR cc: @Julesssss |
In the testing I found that after saving name offline, when the user goes online the previous name shows up for a brief moment. It's not related to this PR. Should I report it on slack? |
Yeah, let's bring it up in Slack separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well for me too 👍
🚀 Deployed to staging by @Julesssss in version: 1.2.12-0 🚀
|
🚀 Deployed to production by @AndrewGable in version: 1.2.12-4 🚀
|
…ave-first-name-last-name-and-time-zone-when-user-is-offline fix/11157 Unable to save first name, last name and time zone when user is offline
Details
At profile page the save button is disabled when the user is offline. We wanna allow the user to save changes even when they are offline. This PR fixes it
Fixed Issues
$ #11157
Tests
PR Review Checklist
Contributor (PR Author) Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
have been tested & I retested again)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)QA Steps
Screenshots
Web
Screen.Recording.2022-09-30.at.09.54.38.mp4
Mobile Web chrome
video-3d54a326-5fab-4251-a23a-fdec7ec4f99a-1664509696.mp4
Mobile Web Safari
Screen.Recording.2022-09-30.at.09.25.51.mp4
Desktop
Screen.Recording.2022-09-30.at.10.28.22.mp4
iOS
Screen.Recording.2022-09-30.at.11.15.37.mp4
Android
Screen.Recording.2022-09-30.at.10.42.22.mp4