Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the edit comment input getting focus when long-pressing on Android #13593
Fix the edit comment input getting focus when long-pressing on Android #13593
Changes from 4 commits
97d2843
50b4e2d
ebbb2ac
455cb41
a7674d4
fa187d8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was testing this at physical android device and I experienced that the edit composer shakes a lit bit sometimes and sometimes the keyboard doesn't open
Screenrecording_20221215_154054.mp4
I think we can increase the delay. Maybe let's use 100ms same as here
App/src/pages/home/report/ReportActionCompose.js
Line 360 in 21d9ad7
At 100ms -
Screenrecording_20221215_164307.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, thank you for that testing! I originally had it set to 100, but I was only testing on an emulator (all I have access to) and it worked consistently at 10ms. I'm fine increasing that to 100 👍