Upgrade to react-native-web v0.19.9 #24482
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -60,7 +60,6 @@ | |
| }, | ||
| "dependencies": { | ||
| "@dotlottie/react-player": "^1.6.3", | ||
| "@formatjs/intl-datetimeformat": "^6.10.0", | ||
| "@formatjs/intl-getcanonicallocales": "^2.2.0", | ||
| "@formatjs/intl-listformat": "^7.2.2", | ||
|
|
@@ -163,6 +162,7 @@ | |
| "react-native-url-polyfill": "^2.0.0", | ||
| "react-native-view-shot": "^3.6.0", | ||
| "react-native-vision-camera": "^2.16.2", | ||
| "react-native-web": "^0.19.9", | ||
| "react-native-web-linear-gradient": "^1.1.2", | ||
| "react-native-webview": "^11.17.2", | ||
| "react-pdf": "^6.2.2", | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| diff --git a/node_modules/eslint-plugin-react-native-a11y/__tests__/src/rules/has-valid-accessibility-descriptors-test.js b/node_modules/eslint-plugin-react-native-a11y/__tests__/src/rules/has-valid-accessibility-descriptors-test.js | ||
| index 9ecf8b1..fef94dd 100644 | ||
| --- a/node_modules/eslint-plugin-react-native-a11y/__tests__/src/rules/has-valid-accessibility-descriptors-test.js | ||
| +++ b/node_modules/eslint-plugin-react-native-a11y/__tests__/src/rules/has-valid-accessibility-descriptors-test.js | ||
| @@ -20,7 +20,7 @@ const ruleTester = new RuleTester(); | ||
|
|
||
| const expectedError = { | ||
| message: | ||
| - 'Missing a11y props. Expected one of: accessibilityRole OR BOTH accessibilityLabel + accessibilityHint OR BOTH accessibilityActions + onAccessibilityAction', | ||
| + 'Missing a11y props. Expected one of: accessibilityRole OR role OR BOTH accessibilityLabel + accessibilityHint OR BOTH accessibilityActions + onAccessibilityAction', | ||
| type: 'JSXOpeningElement', | ||
| }; | ||
|
|
||
| @@ -29,6 +29,11 @@ ruleTester.run('has-valid-accessibility-descriptors', rule, { | ||
| { | ||
| code: '<View></View>;', | ||
| }, | ||
| + { | ||
| + code: `<Pressable role="button"> | ||
| + <Text>Back</Text> | ||
| + </Pressable>`, | ||
| + }, | ||
| { | ||
| code: `<Pressable accessibilityRole="button"> | ||
| <Text>Back</Text> | ||
| diff --git a/node_modules/eslint-plugin-react-native-a11y/lib/rules/has-valid-accessibility-descriptors.js b/node_modules/eslint-plugin-react-native-a11y/lib/rules/has-valid-accessibility-descriptors.js | ||
| index 99deb91..555ebd9 100644 | ||
| --- a/node_modules/eslint-plugin-react-native-a11y/lib/rules/has-valid-accessibility-descriptors.js | ||
| +++ b/node_modules/eslint-plugin-react-native-a11y/lib/rules/has-valid-accessibility-descriptors.js | ||
| @@ -16,7 +16,7 @@ function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { de | ||
| // ---------------------------------------------------------------------------- | ||
| // Rule Definition | ||
| // ---------------------------------------------------------------------------- | ||
| -var errorMessage = 'Missing a11y props. Expected one of: accessibilityRole OR BOTH accessibilityLabel + accessibilityHint OR BOTH accessibilityActions + onAccessibilityAction'; | ||
| +var errorMessage = 'Missing a11y props. Expected one of: accessibilityRole OR role OR BOTH accessibilityLabel + accessibilityHint OR BOTH accessibilityActions + onAccessibilityAction'; | ||
| var schema = (0, _schemas.generateObjSchema)(); | ||
|
|
||
| var hasSpreadProps = function hasSpreadProps(attributes) { | ||
| @@ -35,7 +35,7 @@ module.exports = { | ||
| return { | ||
| JSXOpeningElement: function JSXOpeningElement(node) { | ||
| if ((0, _isTouchable.default)(node, context) || (0, _jsxAstUtils.elementType)(node) === 'TextInput') { | ||
| - if (!(0, _jsxAstUtils.hasAnyProp)(node.attributes, ['accessibilityRole', 'accessibilityLabel', 'accessibilityActions', 'accessible']) && !hasSpreadProps(node.attributes)) { | ||
| + if (!(0, _jsxAstUtils.hasAnyProp)(node.attributes, ['role', 'accessibilityRole', 'accessibilityLabel', 'accessibilityActions', 'accessible']) && !hasSpreadProps(node.attributes)) { | ||
| context.report({ | ||
| node, | ||
| message: errorMessage, | ||
| diff --git a/node_modules/eslint-plugin-react-native-a11y/lib/rules/has-valid-accessibility-role.js b/node_modules/eslint-plugin-react-native-a11y/lib/rules/has-valid-accessibility-role.js | ||
| index fe74702..fa6bdaa 100644 | ||
| --- a/node_modules/eslint-plugin-react-native-a11y/lib/rules/has-valid-accessibility-role.js | ||
| +++ b/node_modules/eslint-plugin-react-native-a11y/lib/rules/has-valid-accessibility-role.js | ||
| @@ -13,5 +13,5 @@ function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { de | ||
| // Rule Definition | ||
| // ---------------------------------------------------------------------------- | ||
| var errorMessage = 'accessibilityRole must be one of defined values'; | ||
| -var validValues = ['togglebutton', 'adjustable', 'alert', 'button', 'checkbox', 'combobox', 'header', 'image', 'imagebutton', 'keyboardkey', 'link', 'menu', 'menubar', 'menuitem', 'none', 'progressbar', 'radio', 'radiogroup', 'scrollbar', 'search', 'spinbutton', 'summary', 'switch', 'tab', 'tabbar', 'tablist', 'text', 'timer', 'list', 'toolbar']; | ||
| +var validValues = ['img', 'img button', 'img link', 'togglebutton', 'adjustable', 'alert', 'button', 'checkbox', 'combobox', 'header', 'image', 'imagebutton', 'keyboardkey', 'link', 'menu', 'menubar', 'menuitem', 'none', 'progressbar', 'radio', 'radiogroup', 'scrollbar', 'search', 'spinbutton', 'summary', 'switch', 'tab', 'tabbar', 'tablist', 'text', 'timer', 'list', 'toolbar']; | ||
| module.exports = (0, _validProp.default)('accessibilityRole', validValues, errorMessage); | ||
| \ No newline at end of file |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,7 +11,7 @@ index b63bcfc..bd6419e 100644 | |
| buildPanResponder: () => void; | ||
| getAccDistancePerDirection: (gestureState: PanResponderGestureState) => number; | ||
| diff --git a/node_modules/react-native-modal/dist/modal.js b/node_modules/react-native-modal/dist/modal.js | ||
| index 80f4e75..3ba8b8c 100644 | ||
| --- a/node_modules/react-native-modal/dist/modal.js | ||
| +++ b/node_modules/react-native-modal/dist/modal.js | ||
| @@ -75,6 +75,13 @@ export class ReactNativeModal extends React.Component { | ||
|
|
@@ -28,23 +28,27 @@ index 80f4e75..a88a2ca 100644 | |
| this.shouldPropagateSwipe = (evt, gestureState) => { | ||
| return typeof this.props.propagateSwipe === 'function' | ||
| ? this.props.propagateSwipe(evt, gestureState) | ||
| @@ -453,10 +460,18 @@ export class ReactNativeModal extends React.Component { | ||
| if (this.state.isVisible) { | ||
| this.open(); | ||
| } | ||
| + if (Platform.OS === 'web') { | ||
| + document?.body?.addEventListener?.('keyup', this.handleEscape, true); | ||
| + return; | ||
| + } | ||
| BackHandler.addEventListener('hardwareBackPress', this.onBackButtonPress); | ||
| } | ||
| componentWillUnmount() { | ||
| - BackHandler.removeEventListener('hardwareBackPress', this.onBackButtonPress); | ||
| + if (Platform.OS === 'web') { | ||
| + document?.body?.removeEventListener?.('keyup', this.handleEscape, true); | ||
| + } else { | ||
| + BackHandler.removeEventListener('hardwareBackPress', this.onBackButtonPress); | ||
| + } | ||
| if (this.didUpdateDimensionsEmitter) { | ||
| this.didUpdateDimensionsEmitter.remove(); | ||
| } | ||
| @@ -525,7 +540,7 @@ export class ReactNativeModal extends React.Component { | ||
| } | ||
| return (React.createElement(Modal, Object.assign({ transparent: true, animationType: 'none', visible: this.state.isVisible, onRequestClose: onBackButtonPress }, otherProps), | ||
| this.makeBackdrop(), | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe pin the version of doc to 0.72 like this
https://reactnative.dev/docs/0.72/textinput#inputmode