Create Security.md #28352
Create Security.md #28352
Conversation
This is a new article that needs to be added to ExpensifyHelp.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
melvin-bot
bot
requested review from
dangrous
and removed request for
a team
|
|
||
|
|
||
| - **Enhanced Security and Data Privacy**: We've strengthened our security measures and carefully reviewed our privacy policies to align with GDPR requirements. | ||
| - **Dedicated Data Protection Officer**: We've appointed a dedicated Data Protection Officer who can be reached at privacy@expensify.com for any privacy-related inquiries. |
There was a problem hiding this comment.
| - **Dedicated Data Protection Officer**: We've appointed a dedicated Data Protection Officer who can be reached at privacy@expensify.com for any privacy-related inquiries. | |
| - **Dedicated Data Protection Officer**: We've appointed a dedicated Data Protection Officer who can be reached at [privacy@expensify.com](mailto:privacy@expensify.com) for any privacy-related inquiries. |
This will make it a clickable email link
| - **Vendor Agreements**: We've signed Data Processing Addendums (DPAs) with all our vendors to ensure your data is handled safely during onward transfers. | ||
| - **Transparency**: You can find details about the sub-processors we use on our website. | ||
| - **Privacy Shield Certification**: We maintain certifications for the E.U.-U.S. Privacy Shield and the Swiss-U.S. Privacy Shield, which help secure international data transfers. | ||
| - **GDPR Compliance**: We have a Data Processing Addendum that outlines the terms to meet GDPR requirements. You can request a copy by contacting concierge@expensify.com. |
There was a problem hiding this comment.
| - **GDPR Compliance**: We have a Data Processing Addendum that outlines the terms to meet GDPR requirements. You can request a copy by contacting concierge@expensify.com. | |
| - **GDPR Compliance**: We have a Data Processing Addendum that outlines the terms to meet GDPR requirements. You can request a copy by contacting [concierge@expensify.com](mailto:concierge@expensify.com). |
This will make it a clickable email link
| @@ -0,0 +1,53 @@ | |||
| --- | |||
| title: Security | |||
|
|
|||
There was a problem hiding this comment.
You'll need to add a description: here as well, with a short phrase about the page
There was a problem hiding this comment.
@dangrous @rushatgabhane I updated the issue and included the description. Can you please confirm if what I did is correct? Is there anything else I need to do before this article is published? Thanks!
|
|
||
| # Overview | ||
|
|
||
| We take security seriously. Our measures align with what banks use to protect sensitive financial data. We regularly test and update our security to stay ahead of any threats. Plus, we're checked daily by McAfee for extra reassurance against hackers. You can verify our security strength below or on the <a href="https://www.trustedsite.com/verify?host=all.expensify.com&utm_campaign=mfes_redirect&utm_medium=referral&utm_source=mcafeesecure.com">McAfee SECURE site </a>. |
There was a problem hiding this comment.
| We take security seriously. Our measures align with what banks use to protect sensitive financial data. We regularly test and update our security to stay ahead of any threats. Plus, we're checked daily by McAfee for extra reassurance against hackers. You can verify our security strength below or on the <a href="https://www.trustedsite.com/verify?host=all.expensify.com&utm_campaign=mfes_redirect&utm_medium=referral&utm_source=mcafeesecure.com">McAfee SECURE site </a>. | |
| We take security seriously. Our measures align with what banks use to protect sensitive financial data. We regularly test and update our security to stay ahead of any threats. Plus, we're checked daily by McAfee for extra reassurance against hackers. You can verify our security strength below or on the <a href="https://www.trustedsite.com/verify?host=all.expensify.com&utm_campaign=mfes_redirect&utm_medium=referral&utm_source=mcafeesecure.com">McAfee SECURE site</a>. |
extra space
|
@rushatgabhane not sure where the issue for this one is so figured I'd add you directly |
|
@isabelastisser bump on above |
| --- | ||
| title: Security | ||
|
|
||
| --- |
There was a problem hiding this comment.
Expensify prioritizes data security and maintains strict compliance standards to safeguard users' sensitive information.
| @@ -0,0 +1,53 @@ | |||
| --- | |||
| title: Security | |||
|
|
|||
There was a problem hiding this comment.
@dangrous @rushatgabhane I updated the issue and included the description. Can you please confirm if what I did is correct? Is there anything else I need to do before this article is published? Thanks!
|
@dangrous @rushatgabhane I left a comment/requested the change here, can you please let me know if this is correct? Thanks! |
|
@rushatgabhane - to make this easier for @isabelastisser I can push the changes (including the new description for SEO). to this PR. Do you feel comfortable being the only reviewer on that, or should I grab another internal engineer since technically I can't review it anymore once I've contributed? Thanks! |
|
@dangrous that will be great, please go ahead! |
Deploying with
|
| Latest commit: |
3c47c3e
|
| Status: | 🚫 Build failed. |
|
@rushatgabhane this is updated! I'm not sure why the Cloudflare thing failed; I haven't dealt with that before. Also @isabelastisser do you mind doing one more thing? Can you do this - https://stackoverflowteams.com/c/expensify/questions/7660 - so that the bot is happy? |
|
I have read the CLA Document and I hereby sign the CLA |
|
@dangrous is this all I need to do? Please let me know when the article will be published. Thanks for your help! |
I simply posted a comment above; if that's incorrect, can you share the instructions so I can post a pull request comment? thanks! @dangrous |
|
Yep that's perfect @isabelastisser ! Just need review now from @rushatgabhane and we'll be good to go |
|
Bumping on the review here when you can @rushatgabhane - thank you! |
There was a problem hiding this comment.
@dangrous the cloudflare build is failing because the branch is outdated.
I merged with latest main, and it's working fine.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g.
myBool && <MyComponent />. - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the
Waiting for Copylabel for a copy review on the original GH to get the correct copy. - I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
|
@tylerkaraszewski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🎯 @rushatgabhane, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #30371. |
|
ill merge main and get that last check fixed |
|
A preview of your ExpensifyHelp changes have been deployed to https://8511564b.helpdot.pages.dev ⚡️ |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/dangrous in version: 1.3.92-0 🚀
|
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.92-4 🚀
|
|
🚀 Deployed to staging by https://github.com/dangrous in version: 1.3.93-0 🚀
|
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.93-1 🚀
|
|
Hey @dangrous @tylerkaraszewski @rushatgabhane is the page live? If yes, can you please point me to the article in Expensify help? I searched for it under this section |
This is a new article that needs to be added to ExpensifyHelp.
Details
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android