Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🍒 Cherry pick PR #3481 to staging 🍒 #3501

Merged
merged 2 commits into from
Jun 9, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,8 @@ android {
minSdkVersion rootProject.ext.minSdkVersion
targetSdkVersion rootProject.ext.targetSdkVersion
multiDexEnabled rootProject.ext.multiDexEnabled
versionCode 1001006604
versionName "1.0.66-4"
versionCode 1001006605
versionName "1.0.66-5"
}
splits {
abi {
Expand Down
2 changes: 1 addition & 1 deletion ios/ExpensifyCash/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
</dict>
</array>
<key>CFBundleVersion</key>
<string>1.0.66.4</string>
<string>1.0.66.5</string>
<key>ITSAppUsesNonExemptEncryption</key>
<false/>
<key>LSApplicationQueriesSchemes</key>
Expand Down
2 changes: 1 addition & 1 deletion ios/ExpensifyCashTests/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleVersion</key>
<string>1.0.66.4</string>
<string>1.0.66.5</string>
</dict>
</plist>
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "expensify.cash",
"version": "1.0.66-4",
"version": "1.0.66-5",
"author": "Expensify, Inc.",
"homepage": "https://expensify.cash",
"description": "Expensify.cash is the next generation of Expensify: a reimagination of payments based atop a foundation of chat.",
Expand Down
6 changes: 4 additions & 2 deletions src/libs/Permissions.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,18 @@ function canUseIOU(betas) {
}

/**
* @param {Array<String>} betas
* @returns {Boolean}
*/
function canUsePayWithExpensify() {
function canUsePayWithExpensify(betas) {
return _.contains(betas, CONST.BETAS.PAY_WITH_EXPENSIFY) || canUseAllBetas();
}

/**
* @param {Array<String>} betas
* @returns {Boolean}
*/
function canUseFreePlan() {
function canUseFreePlan(betas) {
return _.contains(betas, CONST.BETAS.FREE_PLAN) || canUseAllBetas();
}

Expand Down
8 changes: 7 additions & 1 deletion src/pages/iou/IOUDetailsModal.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ const propTypes = {
email: PropTypes.string,
}).isRequired,

/** Beta features list */
betas: PropTypes.arrayOf(PropTypes.string).isRequired,

...withLocalizePropTypes,
};

Expand Down Expand Up @@ -181,7 +184,7 @@ class IOUDetailsModal extends Component {
*/
addExpensifyPaymentOptionIfAvailable() {
if (lodashGet(this.props, 'iouReport.currency') !== CONST.CURRENCY.USD
|| !Permissions.canUsePayWithExpensify()) {
|| !Permissions.canUsePayWithExpensify(this.props.betas)) {
return;
}

Expand Down Expand Up @@ -286,5 +289,8 @@ export default compose(
session: {
key: ONYXKEYS.SESSION,
},
betas: {
key: ONYXKEYS.BETAS,
},
}),
)(IOUDetailsModal);