Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: implement accounting page #38283

Closed

Conversation

teneeto
Copy link
Contributor

@teneeto teneeto commented Mar 14, 2024

Details

Implement a new page called "Accounting page" for the QuickBooks Online (QBO) connection project.

Fixed Issues

$ 37706
PROPOSAL: issue Description

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • [] I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • [ x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari

Screenshot 2024-03-14 at 11 14 23

Screenshot 2024-03-14 at 13 03 01

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Desktop

@teneeto teneeto requested a review from a team as a code owner April 3, 2024 08:54
@teneeto
Copy link
Contributor Author

teneeto commented Apr 3, 2024

@teneeto

The More Features page is already available. It was implemented in this PR.

To be able to use the Collect Workspace, currently, you need to do a couple of stuff:

  1. Sign in to staging.expenisfy.com. Use a non-public domain if possible. If you need to use a public domain (e.g., google.com], append ?exitTo=inbox to the URL.
  2. Navigate to Settings -> Workspaces -> Group -> New Workspace -> Collect. This creates a new Collect workspace for you. You do NOT need to enter any payment information.
  3. On the screen for your newly created workspace, open the developer console. Paste and execute the following code snippet:
p = Policy.getCurrent();
p.policy.isPolicyExpenseChatEnabled = true;
p.save();
  1. Sign in to New Expensify using the same account you used in step Some initial fixes and code style updates #1.
  2. Click on your avatar on the far right of the bottom tab -> Workspaces. The workspace you created should be listed. Click on it.
  3. Confirm that the screen you see matches the one shown below.
Screenshot 2024-03-24 at 3 32 40 PM

@hayata-suenaga I'm able to access this, but can't find the accounting connection options.

@hayata-suenaga
Copy link
Contributor

@hayata-suenaga I'm able to access this, but can't find the accounting connection options.

Ah sorry about that. You have to be on the beta for the accounting feature. Could you DM me on Slack the email address you use for the test account so that I can add it to the beta list?

@teneeto
Copy link
Contributor Author

teneeto commented Apr 3, 2024

@teneeto, let me know if you have questions on how to conditionally register the Account Page inside WorkspaceSettingsModalStackNavigator.

this is done now @hayata-suenaga

@teneeto teneeto closed this by deleting the head repository Apr 4, 2024
@teneeto teneeto mentioned this pull request Apr 4, 2024
50 tasks
@teneeto
Copy link
Contributor Author

teneeto commented Apr 4, 2024

My apologies guys. I closed this PR by accident, can we continue review here: #39652

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants