Fix - Add BA thread is missing Add button, incomplete thread header and "Hidden" user #38884

FitseTLT · 2024-03-23T19:17:35Z

Details

Fixed Issues

$ #38126
PROPOSAL: #38126 (comment)

Tests

Precondition:

Admin and employee are in the Collect workspace.
Admin has a business bank account added to the workspace.
Employee does not have a bank account.

[Employee] Go to staging.new.expensify.com.
[Employee] Go to workspace chat and create a manual request and submit.
[Admin] Approve the request.
[Employee] Go to expense report.
[Employee] Right click on "started settling up," message > Reply in thread.
Verify that the thread header contains the whole parent message
Verify that the parent message in the thread contains the whole message with the correct user display name instead of Hidden
Verify that the add bank account button exists on this parent message of the thread and click on it and check it works properly.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

nat.mp4

Android: mWeb Chrome

a.w.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

i.w.mp4

MacOS: Chrome / Safari

w.mp4

MacOS: Desktop

d.mp4

melvin-bot · 2024-03-23T19:17:40Z

@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

FitseTLT · 2024-03-26T08:18:12Z

bump @akinwale

akinwale · 2024-03-26T12:07:58Z

Thanks for the bump. I'll review this later today or tomorrow at the latest.

akinwale · 2024-03-28T10:57:44Z

Reviewing today.

akinwale · 2024-03-29T07:06:21Z

@FitseTLT I am unable to complete the business bank account process as I'm stuck on step 5 and I am unable to use the Pay with Expensify button. How did you get past this?

FitseTLT · 2024-03-29T07:44:50Z

@FitseTLT I am unable to complete the business bank account process as I'm stuck on step 5 and I am unable to use the Pay with Expensify button. How did you get past this?

You need to make use staging server on.

akinwale · 2024-03-29T07:55:22Z

@FitseTLT I am unable to complete the business bank account process as I'm stuck on step 5 and I am unable to use the Pay with Expensify button. How did you get past this?

You need to make use staging server on.

Yes, I already did this and completed the steps up to the last step. Then I'm asked to chat to finish setup.

FitseTLT · 2024-04-01T11:01:26Z

Here is how I finished the flow @akinwale

2024-04-01.13-59-25.mp4

akinwale · 2024-04-01T11:04:49Z

Here is how I finished the flow @akinwale

Ah, I see. That's the wallet flow which is different from the VBA flow. I'll get this set up and then I should be able to finish the review. Thanks.

FitseTLT · 2024-04-04T13:30:48Z

bump @akinwale

akinwale · 2024-04-04T13:50:58Z

@FitseTLT I'm still stuck trying to test settling a payment as the workspace admin. Even after adding a bank account, I get stuck in a loop as shown in this video. Any ideas?

bba-loop.mp4

FitseTLT · 2024-04-04T13:56:40Z

@akinwale What we need to test is totally different to what you are showing me.
First you set reimbursement bank account as admin in old dot

while the employee bank account is not set then when you approve any iou report the Add bank account message will appear and it is what you should proceed with the test on by replying in thread on the message ... bla bla

akinwale · 2024-04-04T14:02:07Z

Ah, I see. I was working under the assumption that the workspace admin should have a bank account which would be used to settle the employee IOU (based on the listed test preconditions). Thanks for the clarification. I will have another look in a couple of hours.

FitseTLT · 2024-04-04T14:21:00Z

Nope U only add bank account on the collect policy (reimbursement -> Direct). YOur workspace should have USD default currency and then on OD U can follow this instruction. Now, when u approve an employee's report who hasn't set their bank account that started settling up, payment is held until ... message comes 👍

akinwale · 2024-04-05T11:09:00Z

Reviewing today.

akinwale · 2024-04-08T06:35:31Z

Ok, finally got it to work. Will finish reviewing shortly. The Add bank account message shows up after the request is approved, not after payment, which is where I got mostly confused as I kept trying to "Pay with Expensify" which is where I got stuck. I also did not have the Reimbursement setting set correctly on OD.

@FitseTLT Please update the test steps as follows:

Precondition:
~~Admin has bank account account.~~
Admin has a business bank account added to the workspace.

Also need to add this to the preconditions.

Policy Reimbursement is set to Direct on Old Dot.

Test step:
~~[Admin] Pay the request with Expensify.~~
[Admin] Approve the request.

akinwale · 2024-04-08T06:56:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

38884-android-native.mp4

Android: mWeb Chrome

38884-android-chrome.mp4

iOS: Native

38884-ios-native.mp4

iOS: mWeb Safari

38884-ios-safari.mp4

MacOS: Chrome / Safari

38884-web.mp4

MacOS: Desktop

38884-desktop.mp4

akinwale

Looks good.

@FitseTLT Please fix the test steps and then I can approve.

FitseTLT · 2024-04-08T10:10:43Z

Ok, finally got it to work. Will finish reviewing shortly. The Add bank account message shows up after the request is approved, not after payment, which is where I got mostly confused as I kept trying to "Pay with Expensify" which is where I got stuck. I also did not have the Reimbursement setting set correctly on OD.

@FitseTLT Please update the test steps as follows:

Precondition: ~~Admin has bank account account.~~ Admin has a business bank account added to the workspace.

Also need to add this to the preconditions.

Policy Reimbursement is set to Direct on Old Dot.

Test step: ~~[Admin] Pay the request with Expensify.~~ [Admin] Approve the request.

Wooh. Very very sorry @akinwale I have really played a substantial role in your confusion, it really surprised me when I saw it was like that. I have updated according to your request but only this part

Policy Reimbursement is set to Direct on Old Dot.

, I think, would add more confusion because it is already included in this step Precondition: ~Admin has bank account account.~ Admin has a business bank account added to the workspace. Thnx

akinwale

LGTM.

chiragsalian

Code LGTM, there just an unnecessary line break to remove and then I'll approve and merge this.

src/libs/ReportUtils.ts

FitseTLT · 2024-04-12T08:59:52Z

Let's merge this @chiragsalian

OSBotify · 2024-04-15T19:17:51Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-18T04:55:02Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.4.63-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-22T14:56:01Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Ollyws · 2024-05-23T11:31:50Z

src/libs/ReportUtils.ts

+        return '';
+    }
+    if (ReportActionsUtils.isApprovedOrSubmittedReportAction(reportAction)) {
+        return ReportActionsUtils.getReportActionMessageText(reportAction);


This was getting the non-localized message from the backend, causing #41202 which we fixed in #41884

fix chat thread reimbursement queued action bugs

0d13ebc

FitseTLT requested a review from a team as a code owner March 23, 2024 19:17

melvin-bot bot removed the request for review from a team March 23, 2024 19:17

melvin-bot bot requested a review from akinwale March 23, 2024 19:17

Merge branch 'main' into fix-add-bank-account-report-action-bugs

56a1fb8

Merge branch 'main' into fix-add-bank-account-report-action-bugs

86ebe65

changed exitReportID to top most report id

f91b49a

Merge branch 'main' into fix-add-bank-account-report-action-bugs

81520a0

Merge branch 'main' into fix-add-bank-account-report-action-bugs

815a8e4

akinwale reviewed Apr 8, 2024

View reviewed changes

akinwale approved these changes Apr 8, 2024

View reviewed changes

melvin-bot bot requested a review from chiragsalian April 8, 2024 11:25

chiragsalian requested changes Apr 9, 2024

View reviewed changes

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

FitseTLT added 3 commits April 9, 2024 20:54

removed unnecessary break

4d9f280

Merge branch 'main' into fix-add-bank-account-report-action-bugs

6386791

remove assertion

80d9648

FitseTLT requested a review from chiragsalian April 10, 2024 08:34

Merge branch 'main' into fix-add-bank-account-report-action-bugs

4a27fc0

chiragsalian approved these changes Apr 15, 2024

View reviewed changes

chiragsalian merged commit 159628b into Expensify:main Apr 15, 2024
15 checks passed

github-actions bot mentioned this pull request Apr 18, 2024

Deploy Checklist: New Expensify 2024-04-18 #40392

Closed

gijoe0295 mentioned this pull request Apr 21, 2024

Remove exported getReport() #40523

Open

50 tasks

Ollyws reviewed May 23, 2024

View reviewed changes

Ollyws mentioned this pull request May 23, 2024

[HOLD for payment 2024-05-22] Hold expense - Thread header for system message is different from the actual system message #41202

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix - Add BA thread is missing Add button, incomplete thread header and "Hidden" user #38884

Fix - Add BA thread is missing Add button, incomplete thread header and "Hidden" user #38884

FitseTLT commented Mar 23, 2024 •

edited

melvin-bot bot commented Mar 23, 2024

FitseTLT commented Mar 26, 2024

akinwale commented Mar 26, 2024

akinwale commented Mar 28, 2024

akinwale commented Mar 29, 2024

FitseTLT commented Mar 29, 2024

akinwale commented Mar 29, 2024

FitseTLT commented Apr 1, 2024

akinwale commented Apr 1, 2024

FitseTLT commented Apr 4, 2024

akinwale commented Apr 4, 2024

FitseTLT commented Apr 4, 2024

akinwale commented Apr 4, 2024

FitseTLT commented Apr 4, 2024

akinwale commented Apr 5, 2024

akinwale commented Apr 8, 2024 •

edited

akinwale commented Apr 8, 2024

akinwale left a comment

FitseTLT commented Apr 8, 2024 •

edited

akinwale left a comment

chiragsalian left a comment

FitseTLT commented Apr 12, 2024

OSBotify commented Apr 15, 2024

OSBotify commented Apr 18, 2024

OSBotify commented Apr 22, 2024

Ollyws May 23, 2024

Fix - Add BA thread is missing Add button, incomplete thread header and "Hidden" user #38884

Fix - Add BA thread is missing Add button, incomplete thread header and "Hidden" user #38884

Conversation

FitseTLT commented Mar 23, 2024 • edited

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 23, 2024

FitseTLT commented Mar 26, 2024

akinwale commented Mar 26, 2024

akinwale commented Mar 28, 2024

akinwale commented Mar 29, 2024

FitseTLT commented Mar 29, 2024

akinwale commented Mar 29, 2024

FitseTLT commented Apr 1, 2024

akinwale commented Apr 1, 2024

FitseTLT commented Apr 4, 2024

akinwale commented Apr 4, 2024

FitseTLT commented Apr 4, 2024

akinwale commented Apr 4, 2024

FitseTLT commented Apr 4, 2024

akinwale commented Apr 5, 2024

akinwale commented Apr 8, 2024 • edited

akinwale commented Apr 8, 2024

Reviewer Checklist

Screenshots/Videos

akinwale left a comment

Choose a reason for hiding this comment

FitseTLT commented Apr 8, 2024 • edited

akinwale left a comment

Choose a reason for hiding this comment

chiragsalian left a comment

Choose a reason for hiding this comment

FitseTLT commented Apr 12, 2024

OSBotify commented Apr 15, 2024

OSBotify commented Apr 18, 2024

OSBotify commented Apr 22, 2024

Ollyws May 23, 2024

Choose a reason for hiding this comment

FitseTLT commented Mar 23, 2024 •

edited

akinwale commented Apr 8, 2024 •

edited

FitseTLT commented Apr 8, 2024 •

edited