-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Unable to confirm on double check Personal info page, error appears #39012
Conversation
@s77rt Do you have any hint how to reproduce Onfido error on |
@tienifr No not really as I was not able to reproduce on dev, not sure why. Were you able to see what errors Onfido returns? Were the error messages based on user selected language? |
I couldn't.
No, it's always in English. I did try some validation errors but they are all catched by our BE. |
Something is confusing, how did you find out that error messages are in English if you were not able to see any error? |
@tienifr ^ |
Check today. |
Any updates here? |
@s77rt I found the root problem of this: The Content-Security-Policy set in the backend is lacking This happens on both staging and production. This is very critical since access to Onfido SDK is no longer working. And this requires a fix the backend. There's a suggested solution by Onfido here. It has nothing to do with the personal data. |
About the error returned by Onfido, I cannot really find any way to reproduce an Onfido error in Expensify dev. I tried their sample app here and set the language to Spanish/Chinese but the error message is always in English: |
Their error message is generic too. It's not worth using over ours. We'd be just losing translation this way. |
That would be better. Order: onfido field error message > onfido error message > generic error message |
@s77rt I think we only need to show Onfido error |
I think closing makes sense in this case |
Details
This PR shows detailed error from Onfido if possible instead of the generic one.
Fixed Issues
$ #38201
PROPOSAL: #38201 (comment)
Tests
011401533
and1111222233331111
for Routing number and Account number.First
andLast
for first name and last name.Offline tests
NA
QA Steps
011401533
and1111222233331111
for Routing number and Account number.First
andLast
for first name and last name.PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-03-27.at.12.14.34-compressed.mov
Android: mWeb Chrome
Screen.Recording.2024-03-27.at.12.15.55-compressed.mov
iOS: Native
Screen.Recording.2024-03-27.at.12.08.02-compressed.mov
iOS: mWeb Safari
Screen.Recording.2024-03-27.at.12.08.39-compressed.mov
MacOS: Chrome / Safari
Screen.Recording.2024-03-27.at.03.06.57-compressed.mov
MacOS: Desktop
Screen.Recording.2024-03-27.at.03.06.57-compressed.mov