Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Configured Reanimated 2 for Drawer #4081

Merged
merged 2 commits into from
Jul 16, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Jul 15, 2021

Details

Fixed Issues

$ #3972

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@parasharrajat parasharrajat changed the title Configured Reanimated 2 for Drawer [No QA] Configured Reanimated 2 for Drawer Jul 15, 2021
@parasharrajat parasharrajat marked this pull request as ready for review July 15, 2021 21:27
@parasharrajat parasharrajat requested a review from a team as a code owner July 15, 2021 21:27
@MelvinBot MelvinBot requested review from mountiny and removed request for a team July 15, 2021 21:27
@@ -86,7 +86,7 @@
"react-native-permissions": "^3.0.1",
"react-native-picker-select": "8.0.4",
"react-native-plaid-link-sdk": "^7.0.5",
"react-native-reanimated": "^2.1.0",
"react-native-reanimated": "^2.3.0-alpha.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you just do npm i react-native-reanimated@next ? Latest release on GH looks like 2.2.0.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I picked the most stable from the website https://docs.swmansion.com/react-native-reanimated/docs

Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, this looks good to me.

Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mountiny mountiny merged commit 96de1bc into Expensify:main Jul 16, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@marcaaron
Copy link
Contributor

Please do update pods and commit the result anytime a package.json version is changed

diff --git a/ios/Podfile.lock b/ios/Podfile.lock
index 05fe3d6ea..1e8aa5bea 100644
--- a/ios/Podfile.lock
+++ b/ios/Podfile.lock
@@ -461,7 +461,7 @@ PODS:
     - React-Core
   - RNPermissions (3.0.1):
     - React-Core
-  - RNReanimated (2.1.0):
+  - RNReanimated (2.3.0-alpha.1):
     - DoubleConversion
     - FBLazyVector
     - FBReactNativeSpec

this change should have been included here 🙃

@parasharrajat
Copy link
Member Author

Oh sorry. Totally forgot that I upgraded to the version to pod needs to updated as well.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.79-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.80-2🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@parasharrajat parasharrajat deleted the animated-2 branch November 20, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants