-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
40211 handle conflict mapview event on android #41603
40211 handle conflict mapview event on android #41603
Conversation
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && .
Given the above checkbox has to be checked on both our checklists, I noticed that you're checking ListFooterComponent
directly which is typed as React.ReactElement
and this can be problematic if say a string is passed.
We should make sure that we're evaluating a boolean, and for this I suggest React.isValidElement
to wrap ListFooterComponent
which checks whether a value is a React element -> returning a boolean.
You can apply this to the styles check too!
Note: Make sure to run prettier once you're done with the modifications.
cc @suneox
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ListFooterComponent has type is React.ReactElement | undefinded so string or number can't match with this type so I'm also updated
Reviewer Checklist
Screenshots/VideosAndroid: Nativescreen-20240502-115730.mp4Android: mWeb Chromeandroid-mweb.mp4iOS: Nativeios.MP4iOS: mWeb Safariios-mweb.MP4MacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
Adhoc build workflow is in progress. |
This comment has been minimized.
This comment has been minimized.
Trying again... |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks great and it's probably good to go. I'm going to hold off on merging until I can test on a physical Android device this evening. If someone wants to test and merge before then that's fine too.
It tests really well thanks! I don't think we need to wait for David. Merging 🚀 map-swipe.MOV |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.4.72-0 🚀
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.72-1 🚀
|
Details
Fixed Issues
$ #40211
PROPOSAL: #40211 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
screen-20240503-080800.mp4
Android: mWeb Chrome
screen-20240503-100035.mp4
iOS: Native
Screen.Recording.2024-05-03.at.14.21.15.mov
iOS: mWeb Safari
Screen.Recording.2024-05-03.at.08.38.09.mov
MacOS: Chrome / Safari
Screen.Recording.2024-05-03.at.08.18.10.mov
MacOS: Desktop
Screen.Recording.2024-05-03.at.08.26.10.mov