[CP Staging] Use `whisperedTo` instead of `whisperedToAccountIDs` #41856

marcaaron · 2024-05-08T17:53:00Z

Details

cc @luacmartins still gotta fix the TypeScript errors on this and do some testing, but is what I'm thinking.

Fixed Issues

$ #41464

Tests

As User A create a workspace
Create a public workspace room
Give the workspace room a description
As User B access the workspace room
Verify the whisper message displays
Verify there are no multiple whisper messages displayed.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Dead phone atm

Android: mWeb Chrome

Dead phone atm

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-05-08T17:53:05Z

@jayeshmangwani @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jayeshmangwani · 2024-05-08T17:59:04Z

@marcaaron Is a C+ review needed here? Or is @luacmartins is going to take care of the checklist?

marcaaron · 2024-05-08T18:46:26Z

I think we can still have you test on all platforms if you will be around for the next couple of hours.

jayeshmangwani · 2024-05-08T18:47:46Z

Yes sure, I am around for the next few hours

marcaaron · 2024-05-08T18:47:46Z

@jayeshmangwani Mainly looking for regressions related to any whisper messages if you can help think of any cases we need to test. I still need to write up test steps and figure out how to fix the TS errors 🥲

luacmartins

Left one NAB, rest looks good.

luacmartins · 2024-05-08T21:22:08Z

tests/unit/ReportUtilsTest.ts

@@ -5,6 +5,7 @@ import * as ReportUtils from '@libs/ReportUtils';
 import CONST from '@src/CONST';
 import ONYXKEYS from '@src/ONYXKEYS';
 import type {PersonalDetailsList, Policy, Report, ReportAction} from '@src/types/onyx';
+import type {ModifiedExpenseAction} from '@src/types/onyx/ReportAction';


NAB it seems like we still have one reference to whisperedToAccountIDs on line 48

luacmartins · 2024-05-08T21:22:30Z

@jayeshmangwani how's testing going?

jayeshmangwani · 2024-05-08T21:35:09Z

@luacmartins The test looks good to me; everything works fine.

I tested simultaneously with five users, and now we can not see the other user's whisper message, so thats is working fine.

I tested Whisper for moderation, and it's working fine too.

github-actions · 2024-05-08T22:13:46Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/41856/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/41856/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/41856/NewExpensify.dmg	https://41856.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

jayeshmangwani · 2024-05-08T22:29:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android-mweb-chrome.mp4

Android: mWeb Chrome

Android-mweb-chrome.mp4

iOS: Native

ios-web.mov

iOS: mWeb Safari

desktop-mweb-safri.mov

MacOS: Chrome / Safari

ios-web.mov

MacOS: Desktop

desktop-mweb-safri.mov

jayeshmangwani

LGTM 🚀

melvin-bot · 2024-05-08T22:30:31Z

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

marcaaron · 2024-05-08T22:36:11Z

Gonna send this one since we have enough reviews thanks y'all 🙇

@roryabraham you might want to look at this whenever you get a chance OR we can chat in a new issue and continue the convo about fixing up the types.

OSBotify · 2024-05-08T22:43:35Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…ToAccountIDs [CP Staging] Use `whisperedTo` instead of `whisperedToAccountIDs` (cherry picked from commit 710f2a2)

OSBotify · 2024-05-08T23:31:08Z

🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 1.4.71-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

zsgreenwald · 2024-05-08T23:35:14Z

Got this when trying to test web using the QR code/link above

OSBotify · 2024-05-09T02:14:13Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.71-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mountiny · 2024-05-09T08:46:07Z

@zsgreenwald That is expected issue with the AdHoc QR code builds. After clicking back in top left of the app, it will lead you to normal chat page

marcaaron added 2 commits May 8, 2024 07:44

Use whisperedTo instead of whisperedToAccountIDs

a37d8dd

Add comment

c7ad73c

marcaaron requested a review from luacmartins May 8, 2024 17:53

marcaaron self-assigned this May 8, 2024

marcaaron requested a review from a team as a code owner May 8, 2024 17:53

melvin-bot bot requested review from jayeshmangwani and removed request for a team May 8, 2024 17:53

marcaaron added 5 commits May 8, 2024 09:38

Add ReportActionMessageJSON

711a982

Try to workaround TS temporarily

a2ead7f

Create more specific ModifiedExpenseAction

5ab6a0f

Add ReportActionMessageJSON

5bdec60

Prettier

a8cee69

luacmartins previously approved these changes May 8, 2024

View reviewed changes

Fix last whisperedToAccountIDs

29efe8e

marcaaron dismissed luacmartins’s stale review via 29efe8e May 8, 2024 21:34

luacmartins approved these changes May 8, 2024

View reviewed changes

marcaaron added the Ready To Build label May 8, 2024

marcaaron changed the title ~~Use whisperedTo instead of whisperedToAccountIDs~~ [CP Staging] Use whisperedTo instead of whisperedToAccountIDs May 8, 2024

marcaaron mentioned this pull request May 8, 2024

Deploy Checklist: New Expensify 2024-05-07 #41716

Closed

jayeshmangwani approved these changes May 8, 2024

View reviewed changes

melvin-bot bot requested a review from marcochavezf May 8, 2024 22:30

marcaaron removed the request for review from marcochavezf May 8, 2024 22:35

marcaaron merged commit 710f2a2 into main May 8, 2024
17 of 19 checks passed

marcaaron deleted the marcaaron-deprecateWhisperedToAccountIDs branch May 8, 2024 22:36

OSBotify pushed a commit that referenced this pull request May 8, 2024

Merge pull request #41856 from Expensify/marcaaron-deprecateWhispered…

f23ec89

…ToAccountIDs [CP Staging] Use `whisperedTo` instead of `whisperedToAccountIDs` (cherry picked from commit 710f2a2)

melvin-bot bot mentioned this pull request May 13, 2024

[HOLD for payment 2024-05-20] [$250] Whispered messages showing to all users temporarily when scrolling #41464

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Use `whisperedTo` instead of `whisperedToAccountIDs` #41856

[CP Staging] Use `whisperedTo` instead of `whisperedToAccountIDs` #41856

marcaaron commented May 8, 2024 •

edited

melvin-bot bot commented May 8, 2024

jayeshmangwani commented May 8, 2024

marcaaron commented May 8, 2024

jayeshmangwani commented May 8, 2024

marcaaron commented May 8, 2024

luacmartins left a comment

luacmartins May 8, 2024

luacmartins commented May 8, 2024

jayeshmangwani commented May 8, 2024

github-actions bot commented May 8, 2024

jayeshmangwani commented May 8, 2024

jayeshmangwani left a comment

melvin-bot bot commented May 8, 2024

marcaaron commented May 8, 2024

OSBotify commented May 8, 2024

OSBotify commented May 8, 2024

zsgreenwald commented May 8, 2024

OSBotify commented May 9, 2024

mountiny commented May 9, 2024

[CP Staging] Use whisperedTo instead of whisperedToAccountIDs #41856

[CP Staging] Use whisperedTo instead of whisperedToAccountIDs #41856

Conversation

marcaaron commented May 8, 2024 • edited

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 8, 2024

jayeshmangwani commented May 8, 2024

marcaaron commented May 8, 2024

jayeshmangwani commented May 8, 2024

marcaaron commented May 8, 2024

luacmartins left a comment

Choose a reason for hiding this comment

luacmartins May 8, 2024

Choose a reason for hiding this comment

luacmartins commented May 8, 2024

jayeshmangwani commented May 8, 2024

github-actions bot commented May 8, 2024

jayeshmangwani commented May 8, 2024

Reviewer Checklist

Screenshots/Videos

jayeshmangwani left a comment

Choose a reason for hiding this comment

melvin-bot bot commented May 8, 2024

marcaaron commented May 8, 2024

OSBotify commented May 8, 2024

OSBotify commented May 8, 2024

zsgreenwald commented May 8, 2024

OSBotify commented May 9, 2024

mountiny commented May 9, 2024

[CP Staging] Use `whisperedTo` instead of `whisperedToAccountIDs` #41856

[CP Staging] Use `whisperedTo` instead of `whisperedToAccountIDs` #41856

marcaaron commented May 8, 2024 •

edited