-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix : iOS keyboard overlaps educational modal for hold #44771
base: main
Are you sure you want to change the base?
fix : iOS keyboard overlaps educational modal for hold #44771
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
I have read the CLA Document and I hereby sign the CLA |
recheck |
Updated video for iOS-native Screen.Recording.2024-07-03.at.9.55.25.PM.mov |
@parasharrajat I have updated the PR. please check |
@Sparth19 I see there is some delay before keyboard is closed. How can we solve this? Don't show the keyboard at all if HOld menu is about to be shown. |
…board-overlaps-educational-modal
@parasharrajat I resolved your comment with a better approach and also addressed the issue of brief keyboard movement when navigating to the hold reason screen. also updated the PR. Screen.Recording.2024-07-05.at.7.04.45.PM.mov |
@Sparth19 Could you please merge main? |
…board-overlaps-educational-modal
@parasharrajat I have merged the main in this PR. |
…board-overlaps-educational-modal
Screenshots🔲 iOS / native10.07.2024_02.24.38_REC.mp4🔲 iOS / Safari🔲 MacOS / Desktop🔲 MacOS / Chrome🔲 Android / Chrome🔲 Android / native |
I am facing a few issues while testing this PR. I will try to wrap this one tomorrow. |
Details
Fixed Issues
$ #43989
PROPOSAL: #43989(comment)
Tests
Precondition: user is a member of a workspace
Offline tests
QA Steps
Precondition: user is a member of a workspace
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android_native.mov
Android: mWeb Chrome
iOS: Native
IOS_native.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop