Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop adding duplicate members #4510

Merged
merged 1 commit into from
Aug 11, 2021
Merged

stop adding duplicate members #4510

merged 1 commit into from
Aug 11, 2021

Conversation

aman-atg
Copy link
Contributor

@aman-atg aman-atg commented Aug 9, 2021

Details

#4307 (comment)

Fixed Issues

$ #4307

Tests || QA Steps

  1. Go to a workspace
  2. Choose People Tab
  3. Invite yourself or someone who's already a member
  4. An Error msg will be shown

Tested On

  • Web
  • Mobile Web
  • Android
  • Please test on these two
  • Desktop
  • iOS

Screenshots

Web

image

Mobile Web

mWeb.mp4

Desktop

iOS

Android

M.mp4

@aman-atg aman-atg requested a review from a team as a code owner August 9, 2021 18:16
@MelvinBot MelvinBot requested review from deetergp and removed request for a team August 9, 2021 18:16
deetergp
deetergp approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@deetergp deetergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and tests well 👍

@deetergp deetergp merged commit a4d44e1 into Expensify:main Aug 11, 2021
@OSBotify OSBotify mentioned this pull request Aug 11, 2021
Closed
53 tasks
@botify
Copy link

botify commented Aug 17, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-08-24. 🎊

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @isagoico in version: 1.0.85-9 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@parasharrajat parasharrajat mentioned this pull request Aug 23, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deetergp deetergp deetergp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aman-atg @botify @OSBotify @deetergp