Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a growl when trying to create a chat with an invalid phone number #4525

Merged
merged 1 commit into from
Aug 11, 2021
Merged

Show a growl when trying to create a chat with an invalid phone number #4525

merged 1 commit into from
Aug 11, 2021

Conversation

rdjuric
Copy link
Contributor

@rdjuric rdjuric commented Aug 10, 2021

Details

Shows an error Growl when trying to create a invalid chat.

Fixed Issues

$ #2934

Tests

  1. Search for an invalid number (like +5512)
  2. Click on the result
  3. A Growl shows up with the correct error message

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web.mov

Mobile Web

mWeb.mp4

Desktop

desktop.mov

iOS

iOS.mp4

Android

Android.mp4

@rdjuric rdjuric marked this pull request as ready for review August 10, 2021 20:38
@rdjuric rdjuric requested a review from a team as a code owner August 10, 2021 20:38
@MelvinBot MelvinBot requested review from cead22 and removed request for a team August 10, 2021 20:38
@rdjuric rdjuric changed the title growl when creating invalid chat Show a growl when trying to create a chat with an invalid phone number Aug 10, 2021
@Beamanator Beamanator self-requested a review August 11, 2021 07:46
Copy link
Contributor

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 (sorry @cead22 , stealing this)

@Beamanator Beamanator merged commit 83dd58e into Expensify:main Aug 11, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Beamanator in version: 1.0.83-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Aug 17, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-08-24. 🎊

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @isagoico in version: 1.0.85-9 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants