Remove unnecessary withOnyx from chat messages #4573
Conversation
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
| currentDate: { | ||
| key: ONYXKEYS.CURRENT_DATE, | ||
| }, | ||
| }), |
There was a problem hiding this comment.
Hey @marcaaron I've noticed this component does not use the date received from Onyx at all
Is this something we're passing to force a re-render?
There was a problem hiding this comment.
Hmm that's a good question. I didn't look into the original intention behind why this subscription was added. Maybe we can look at the git blame to find out more.
There was a problem hiding this comment.
Original PR is here -> https://github.com/Expensify/App/pull/3573/files
I think the intention is to force a re-render.
|
🚀 Deployed to production by @roryabraham in version: 1.0.86-11 🚀
|
Details
Missed this when creating the context provider - there is an additional
withOnyx()getting connected to each chat message slowing down chat rendering. There is more context about this in the original PR that added theOnyxProviderhere -> #4348cc @kidroca
Fixed Issues (Related To)
#4022
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android