Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Inline code block styling #4624

Merged
merged 2 commits into from
Aug 16, 2021
Merged

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Aug 12, 2021

Details

Fixed Issues

$ Fixes #4005

Tests | QA Steps

  1. Open newDot.
  2. Send some message that contains inline code block.
  3. Observe the UI.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

image

Mobile Web

code-block-m

iOS

code-block-i

Android

code-block-a

@parasharrajat parasharrajat requested a review from a team as a code owner August 12, 2021 20:08
@MelvinBot MelvinBot requested review from johnmlee101 and removed request for a team August 12, 2021 20:08
Copy link
Contributor

@johnmlee101 johnmlee101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@parasharrajat
Copy link
Member Author

A minute please testing on IOS.

@parasharrajat
Copy link
Member Author

Ok @johnmlee101 IOS looks good. Good to go here. Thanks.

@parasharrajat
Copy link
Member Author

parasharrajat commented Aug 13, 2021

Ready to roll. @johnmlee101

@johnmlee101 johnmlee101 merged commit 69ee2fe into Expensify:main Aug 16, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @johnmlee101 in version: 1.0.85-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@isagoico
Copy link

This issue is failing this PR #4733

@botify
Copy link

botify commented Aug 25, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-01. 🎊

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.86-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Aug 30, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-06. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Hold for payment Aug 23rd] InlineCode block is trimmed on Android
5 participants