Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide automated accounts from Recent sections of Split Money/Request Money #4648

Merged
merged 10 commits into from
Aug 18, 2021

Conversation

mananjadhav
Copy link
Collaborator

@mananjadhav mananjadhav commented Aug 13, 2021

@Jag96 Can you please review?

Details

Hide automated accounts like chronos, concierge and receipts from Recent section

Fixed Issues

$ #4411

Tests

  1. Verified chronos and receipts email being hidden from Recent sections when splitting money and requesting money, but still show up when creating a new chat or switching to existing chat

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

** Before Screenshot **
before-screenshot-chronos

Web

hide-automated-acc-split-web

hide-automated-acc-request-web

Mobile Web

hide-automated-acc-split-mweb

hide-automated-acc-request-mweb

Desktop

hide-automated-acc-split-desktop

hide-automated-acc-request-desktop

iOS

hide-automated-acc-split-ios

hide-automated-acc-request-ios

Android

hide-automated-acc-request-android

hide-automated-acc-split-android

@mananjadhav mananjadhav requested a review from a team as a code owner August 13, 2021 17:58
@MelvinBot MelvinBot requested review from Jag96 and removed request for a team August 13, 2021 17:58
@Jag96 Jag96 requested a review from a team August 17, 2021 17:47
@MelvinBot MelvinBot removed the request for review from a team August 17, 2021 17:47
@Jag96 Jag96 requested a review from a team August 17, 2021 17:47
@MelvinBot MelvinBot removed the request for review from a team August 17, 2021 17:47
@Jag96
Copy link
Contributor

Jag96 commented Aug 17, 2021

Been OOO the past few days, will have a look at this tomorrow

@Jag96 Jag96 merged commit 99017bb into Expensify:main Aug 18, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Sep 1, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-08. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants