[No QA] Make Firebase traces an opt-in feature of global Timing class #4697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomatoToaster
approved these changes
Aug 18, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
We are using the sidebar loaded event as an indicator of Time to Interactive as it roughly measures how much time it takes for the app to become usable once the JS bundle is parsed. This metric was previously only sent to Firebase - but it's more useful to have this in Grafana as well.
I'm still evaluating whether or not it's worth keeping this in Firebase so this might be removed in the future.
Fixed Issues
No Issue
Tests
sidebar_loadede.g.Timing:expensify.cash.sidebar_loaded 551QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android