Exclude cards that are not activated #4720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luke9389
approved these changes
Aug 18, 2021
|
This can be taken off hold I believe! (PR on production!) |
stitesExpensify
changed the title
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
This was referenced Aug 25, 2021
|
@MitchExpensify / @stitesExpensify tagging you guys to check if it worked 😬 |
|
@MitchExpensify Friendly bump here :) |
|
Thanks @isagoico! I assigned a card to kevin@otterclub.us, filled in the shipping details, and then checked https://staging.new.expensify.com/settings/payments:
I see the business bank account listed as the payment method |
|
🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Add a new param to prevent the inclusion of non-activated cards
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/172363#
Tests
QA Steps
Ping Mitch Ward on slack to check if it worked
Tested On