Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped expensify-common(Supports nested markdown links) #4750

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

mananjadhav
Copy link
Collaborator

@mananjadhav mananjadhav commented Aug 18, 2021

@tgolen Can you please review and merge this?

Details

Upgrading expensify-common that had a fix for markdown hyperlink regex.

Fixed Issues

$ #4526

Tests

  1. Tests verified for [Text text] more text ([link here](www.google.com))
  2. Fix MD Hyperlink Regex for nested cases expensify-common#407 (review) are additional tests performed.

QA Steps

  1. Need to test the markdown for [Text text] more text ([link here](www.google.com))
  2. Test for [Text text] more text [link here](www.google.com)
  3. [Text text] more text [([link here](www.google.com))]

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Edit Mode to see the markdown text
Screenshot 2021-08-19 at 3 07 08 AM

Rendered Hyperlink
Screenshot 2021-08-19 at 3 06 54 AM

Mobile Web

Screenshot 2021-08-19 at 3 12 11 AM

Desktop

Screenshot 2021-08-19 at 3 12 24 AM

iOS

Screenshot 2021-08-19 at 3 30 24 AM

Android

Screenshot 2021-08-19 at 3 22 52 AM

@mananjadhav mananjadhav requested a review from a team as a code owner August 18, 2021 22:00
@MelvinBot MelvinBot requested review from tgolen and removed request for a team August 18, 2021 22:00
@tgolen tgolen merged commit e5957e1 into Expensify:main Aug 19, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@isagoico
Copy link

@mananjadhav Hello! Any QA tests required for this PR?

@mananjadhav
Copy link
Collaborator Author

@isagoico I've updated few markdowns to test.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Sep 1, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-08. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants