fix: lag between language switch on login page #5300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julesssss
reviewed
Sep 17, 2021
src/libs/actions/Session.js
Outdated
| @@ -298,6 +298,16 @@ function continueSessionFromECom(accountID, validateCode, twoFactorAuthCode) { | |||
| }); | |||
| } | |||
|
|
|||
| /** | |||
| * Clear the creadentials and partial sign in session so the user can taken back to first Login step | |||
There was a problem hiding this comment.
Minor typo: creadentials
Julesssss
previously approved these changes
Sep 17, 2021
|
Oops. Updated @Julesssss |
Julesssss
previously approved these changes
Sep 17, 2021
|
Holding due to N6. |
Julesssss
changed the title
Julesssss
changed the title
|
@parasharrajat this can be merged now, you just need to resolve the conflict 👍 |
parasharrajat
force-pushed
the
picker-lag
branch
from
e41e7e2
to
7e1221e
Compare
|
@Julesssss All set. |
Julesssss
approved these changes
Oct 18, 2021
|
Ready to merge. |
|
@parasharrajat thanks, the iOS build takes forever 😴 |
|
We've tested this against the latest |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @Julesssss in version: 1.1.8-10 🚀
|
|
🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #5068 (comment)
Tests | QA Steps
Tested On
Screenshots
Web
o-s-w.mp4
Mobile Web
o-s-m.mp4
Desktop
iOS
Android
o-s-a.mp4