Use CreateLogin authToken instead of relying on reauthenticate #5438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwiznia
previously approved these changes
Sep 23, 2021
HorusGoul
previously approved these changes
Sep 23, 2021
…n in the CreateLogin response
marcaaron
changed the title
|
Ok taking this one off HOLD now. Should be ready for review. 🙇 |
iwiznia
approved these changes
Oct 22, 2021
HorusGoul
approved these changes
Oct 25, 2021
|
🚀 Deployed to staging by @HorusGoul in version: 1.1.8-15 🚀
|
|
🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Removes code that sends
authTokentoAuthenticateand uses response ofCreateLogininsteadHolding on Web-Expensify 32001 to deploy✅Fixed Issues
$ https://github.com/Expensify/Expensify/issues/178434
Tests
Easy to test on web but slightly trickier on mobile web. You'll need to change the route in Web-Expensify here to go to an ngrok route. So basically set up one ngrok route for
expensify.com.devand also set up a route forlocalhost:8080then modify the web-e code to bring you to the ngrok route forlocalhost:8080. Then you can test the mobile web flow on a mobile device.QA Steps
See https://github.com/Expensify/Web-Expensify/pull/32001
Tested On
The flow we are testing doesn't work on Desktop or iOS because there is no deep link support for the
/transitionroute there yet. For Android technically these links can be used but it is very uncommon for that to happen + I wouldn't necessarily expect it to work. We can look into making the transition work for these platforms but doesn't feel like a priority right now.Screenshots
Web
Mobile Web
Desktop
iOS
Android