show profile errors #5525
Merged
show profile errors #5525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beamanator
reviewed
Sep 28, 2021
Beamanator
reviewed
Sep 29, 2021
Co-authored-by: Alex Beaman <dabeamanator@gmail.com>
Beamanator
approved these changes
Sep 30, 2021
Beamanator
requested changes
Oct 20, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @Beamanator in version: 1.1.8-10 🚀
|
|
🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Proposal: #5091 (comment)
Approval: #5091 (comment)
After this PR is merged, we will be showing error messages when longer names (50+ chars) are being saved.
And profile updation will now wait for the API call to be completed to show the correct msg to user.
Fixed Issues
$ #5091
Tests
QA Steps
Tested On
Screenshots
Web
web.mp4
Mobile Web
mobile.web.mp4
Desktop
iOS
Android
Screenrecorder-2021-09-25-19-23-25-627.mp4