Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shiny up the request call page #5544

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Sep 27, 2021

cc @trjExpensify

Details

  • Updates the request call page to match OldDot
  • Removes the extra information about call scheduling, to be addressed further in this issue.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/179276

Tests / QA Steps.

  1. Open the chat with concierge
  2. Click on the call button
  3. Verify that the request call modal opens and appears as it does in screenshots below.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

Desktop

image

iOS

Android

@roryabraham roryabraham self-assigned this Sep 27, 2021
@roryabraham roryabraham marked this pull request as ready for review September 27, 2021 21:53
@roryabraham roryabraham requested a review from a team as a code owner September 27, 2021 21:53
@MelvinBot MelvinBot requested review from joelbettner and removed request for a team September 27, 2021 21:53
@roryabraham
Copy link
Contributor Author

Also cc @Expensify/design in case anyone with a keen eye has time for a quick review.

@shawnborton
Copy link
Contributor

Looks pretty good to me!

One question though about iOS: it looks like there is a border on top of the content and that the top status bar area is a different color. Is that a new iOS 15 thing? Is there any way to get a clean white bleed without a border up to the top edge of the device like we used to have?
image

@shawnborton
Copy link
Contributor

Looks like Android has this same problem where the top status bar is not a clean bleed with the page. Is that normal?
image

@roryabraham
Copy link
Contributor Author

@shawnborton Let me see what I can do to fix that!

@roryabraham
Copy link
Contributor Author

One question though about iOS: it looks like there is a border on top of the content and that the top status bar area is a different color. Is that a new iOS 15 thing? Is there any way to get a clean white bleed without a border up to the top edge of the device like we used to have?

So I retested and didn't see this border on the iOS native app:

But I do see it on iOS 15 Safari:

However, I think this problem did exist before, it just didn't look wrong because the search bar was on top:

I looked into this a tiny bit, and it seems like it's an issue that just hasn't been addressed in iOS Safari 15 yet AFAIK. The status bar/everything in the browser outside of the website is prettymuch out of our control in Safari.

@shawnborton
Copy link
Contributor

Got it - all of that sounds good to me, thanks for the thorough investigation!

Copy link
Contributor

@joelbettner joelbettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Glad we can be more concise and have everything in the subtitle.

Are there plans in the future to give an estimate for when the user will receive a call?

@joelbettner joelbettner merged commit 56374e8 into main Sep 29, 2021
@joelbettner joelbettner deleted the Rory-RequestCallModalStyle branch September 29, 2021 19:13
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@roryabraham
Copy link
Contributor Author

Are there plans in the future to give an estimate for when the user will receive a call?

Yep! There's an issue for that here!

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @joelbettner in version: 1.1.3-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Oct 4, 2021

🚀 Deployed to production by @chiragsalian in version: 1.1.4-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants