-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shiny up the request call page #5544
Conversation
Also cc @Expensify/design in case anyone with a keen eye has time for a quick review. |
@shawnborton Let me see what I can do to fix that! |
So I retested and didn't see this border on the iOS native app: But I do see it on iOS 15 Safari: However, I think this problem did exist before, it just didn't look wrong because the search bar was on top: I looked into this a tiny bit, and it seems like it's an issue that just hasn't been addressed in iOS Safari 15 yet AFAIK. The status bar/everything in the browser outside of the website is prettymuch out of our control in Safari. |
Got it - all of that sounds good to me, thanks for the thorough investigation! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Glad we can be more concise and have everything in the subtitle.
Are there plans in the future to give an estimate for when the user will receive a call?
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Yep! There's an issue for that here! |
🚀 Deployed to staging by @joelbettner in version: 1.1.3-2 🚀
|
🚀 Deployed to production by @chiragsalian in version: 1.1.4-0 🚀
|
cc @trjExpensify
Details
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/179276
Tests / QA Steps.
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android