Fix invite page not loading after creating new workspace #5729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
36 tasks
|
tested well |
marcaaron
approved these changes
Oct 8, 2021
| @@ -107,7 +107,7 @@ class WorkspaceInvitePage extends React.Component { | |||
| * @returns {Boolean} | |||
| */ | |||
| getShouldShowAlertPrompt() { | |||
| return _.size(lodashGet(this.props.policy, 'errors', {})) > 0 || this.props.policy.alertMessage.length > 0; | |||
| return _.size(lodashGet(this.props.policy, 'errors', {})) > 0 || lodashGet(this.props.policy, 'alertMessage.length') > 0; | |||
There was a problem hiding this comment.
Suggested change
| return _.size(lodashGet(this.props.policy, 'errors', {})) > 0 || lodashGet(this.props.policy, 'alertMessage.length') > 0; | |
| return _.size(lodashGet(this.props.policy, 'errors', {})) > 0 || lodashGet(this.props.policy, 'alertMessage', '').length > 0; |
NAB, maybe slightly more correct?
Otherwise we are doing undefined > 0 which does eval to false but seems weird.
There was a problem hiding this comment.
Made a 2-min PR to implement this real quick.
#5738
github-actions bot
pushed a commit
that referenced
this pull request
Oct 8, 2021
Fix invite page not loading after creating new workspace (cherry picked from commit 13ac792)
|
🚀 Cherry-picked to staging by @Luke9389 in version: 1.1.7-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
Issue fixed! |
5 tasks
|
🚀 Deployed to production by @AndrewGable in version: 1.1.7-24 🚀
|
|
🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Luke9389, please review when you get the chance
CC: @marcaaron
Details
Fixes a TypeError that causes a blank page from the invite modal. This happens after creating a new workspace and then
Fixed Issues
$ #5727
Tests
Same as Web QA done locally
QA Steps
Tested On
Screenshots
Web