Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dismiss top modal before navigating to Concierge chat #5911

Merged
merged 2 commits into from
Oct 19, 2021
Merged

Dismiss top modal before navigating to Concierge chat #5911

merged 2 commits into from
Oct 19, 2021

Conversation

nickmurray47
Copy link
Contributor

@nickmurray47 nickmurray47 commented Oct 16, 2021 •
edited
Loading

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/181177

Tests / QA Steps

  1. Sign up with a public domain email, e.g. nick@google.com
  2. Create workspace
  3. Connect bank account in OPEN state
  4. Go to Issue corporate cards page
  5. Tap [Chat with concierge]
  6. Verify the Concierge chat opens up

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@nickmurray47 nickmurray47 requested a review from a team as a code owner October 16, 2021 01:43
@nickmurray47 nickmurray47 self-assigned this Oct 16, 2021
@MelvinBot MelvinBot requested review from stitesExpensify and removed request for a team October 16, 2021 01:44
@parasharrajat
Copy link
Member

parasharrajat commented Oct 16, 2021 •
edited
Loading

Again. I would say a better way to do is #5131. But as discussed before. I will merge main into my PR and remove this code.

@nickmurray47
Copy link
Contributor Author

Yes, I was just looking if we had a similar method that should navigate back for us. This will do the trick for now but definitely would like to implement your code, too.

@stitesExpensify stitesExpensify merged commit 5b3baae into main Oct 19, 2021
@stitesExpensify stitesExpensify deleted the nmurray-navigate-workspacevbanoecard branch October 19, 2021 01:47
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Oct 23, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @stitesExpensify in version: 1.1.8-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stitesExpensify stitesExpensify stitesExpensify approved these changes

Assignees

@nickmurray47 nickmurray47

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nickmurray47 @parasharrajat @OSBotify @stitesExpensify