Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigate to the Enable Payments Flow from within the Send Money Flow #5928

Merged
merged 6 commits into from
Oct 25, 2021

Conversation

jasperhuangg
Copy link
Contributor

@jasperhuangg jasperhuangg commented Oct 18, 2021

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/169176

Tests

  1. Using an account with a silver wallet (or no wallet), select the "Send Money" option in the global create menu.
  2. Select someone to send money to; it doesn't matter who.
  3. Verify you are taken to the Enable Payments flow, and that you don't proceed with the Send Money flow.
  4. Verify that clicking the close button in the header takes you back to your IOU request.
  5. Test that this flow works for every step of the Enable Payments flow. Since we can't call Web-Secure locally, you can temporarily hardcode the current step here. See CONST.WALLET.STEP for step names.

QA Steps

  1. The testing account must be under the Send Money Beta, and have a Silver Wallet. Select the "Send Money" option in the global create menu.
  2. Select someone to send money to; it doesn't matter who.
  3. Verify you are taken to the Enable Payments flow, and that you don't proceed with the Send Money flow.
  4. Verify that clicking the close button in the header takes you back to your IOU request.
  5. Test that this flow works for every step of the Enable Payments flow.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web.mp4

iOS

ios.mp4

Android

android.mp4

Desktop

desktop.mp4

Mobile Web

(Something wrong with my .env setup, will post later)

cc @nickmurray47

@jasperhuangg jasperhuangg self-assigned this Oct 18, 2021
@jasperhuangg jasperhuangg changed the title Implement KYC Flow within Send Money Flow Navigate to the Enable Payments Flow from within Send Money Flow Oct 18, 2021
@jasperhuangg jasperhuangg changed the title Navigate to the Enable Payments Flow from within Send Money Flow Navigate to the Enable Payments Flow from within the Send Money Flow Oct 18, 2021
@jasperhuangg jasperhuangg marked this pull request as ready for review October 19, 2021 18:28
@jasperhuangg jasperhuangg requested a review from a team as a code owner October 19, 2021 18:28
@MelvinBot MelvinBot requested review from danieldoglas and removed request for a team October 19, 2021 18:29
@danieldoglas danieldoglas requested a review from a team October 21, 2021 19:15
@MelvinBot MelvinBot requested review from HorusGoul and removed request for a team October 21, 2021 19:16
@jasperhuangg jasperhuangg removed the request for review from danieldoglas October 25, 2021 18:16
@jasperhuangg jasperhuangg merged commit 3d675a4 into main Oct 25, 2021
@jasperhuangg jasperhuangg deleted the jasper-sendMoneyKYCFlow branch October 25, 2021 18:17
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @jasperhuangg in version: 1.1.8-21 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants